974317 - Server needs to accept a new incoming call

Status: VERIFIED FIXED

(Hello (Loop) :: Server, defect)

Description

[Alexis Metaireau (:alexis)]

Once we served the webapp to the client, we need an URL where the client can send its calls.

It should accept a session token (relatively similar to the one discussed in Bug 971994) in order to find back the user that should be called and should notify the registered simple push url that something is happening.

Comment 4

[Alexis Metaireau (:alexis)]

Attachment: link to github PR

This PR changes a bunch of stuff at once, rather than trying to isolate the changes;

It is built on top of bug 971999 which should indeed be reviewed first.

Comment 5

[Alexis Metaireau (:alexis)]

Attachment: link to github PR

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 8392756 [details] [review]
link to github PR

I've finished the first round of comments, I'd like to take a look at the responses/changes once they are done.

Comment 7

[Alexis Metaireau (:alexis)]

Attachment: link to github PR

With the comments addressed

Comment 8

[Mark Banner (:standard8)]

Comment on attachment 8392884 [details] [review]
link to github PR

There's a couple of comments left to address on the PR, otherwise it looks good. r=Standard8

Comment 9

[Alexis Metaireau (:alexis)]

https://github.com/mozilla/loop-server/commit/c8de86b20e2ee8937c95d24007b7cad662a86ca3

Comment 10

[James Bonacci [:jbonacci]]

All these changes long since merged and in some cases changed.
Closing these older bugs.