Closed Bug 974322 Opened 7 years ago Closed 7 years ago

Separate AAC/AVC to other items

Categories

(Core :: Audio/Video: Recording, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: ayang, Assigned: ayang)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 2 obsolete files)

AVC and VP8 use the same items, I_FRAME, B_FRAME and P_FRAME. It should be able to distinguish. Same problem for AUDIO_FRAME.

[1] http://dxr.mozilla.org/mozilla-central/source/content/media/encoder/EncodedFrameContainer.h#50
Blocks: MediaEncoder
Attached patch rename_avc_aac_name (obsolete) — Splinter Review
Assignee: nobody → ayang
Attachment #8378190 - Flags: review?(cpearce)
Comment on attachment 8378190 [details] [diff] [review]
rename_avc_aac_name

Review of attachment 8378190 [details] [diff] [review]:
-----------------------------------------------------------------

Should you also add a major type as well (VP8, AVC, AAC, AMR), so you can distinguish a VP8 I-Frame from a AVC I-frame?
Attachment #8378190 - Flags: review?(cpearce) → review+
Attached patch rename_avc_aac_name (obsolete) — Splinter Review
Yes, this patch updated VP8 as well.
Carry r+.
Attachment #8378190 - Attachment is obsolete: true
Attachment #8380465 - Flags: review+
carry r+
Attachment #8380465 - Attachment is obsolete: true
Attachment #8380473 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/1c6419eb5b0d
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Component: Video/Audio → Video/Audio: Recording
You need to log in before you can comment on or make changes to this bug.