Closed Bug 974358 Opened 6 years ago Closed 6 years ago

Add TBPL support for web-platform-tests

Categories

(Tree Management Graveyard :: TBPL, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: emorley, Assigned: emorley)

References

Details

Attachments

(1 file)

https://tbpl.mozilla.org/?tree=Cedar&jobname=web-platform-tests

eg:
Rev4 MacOSX Snow Leopard 10.6 cedar debug test web-platform-tests
Rev4 MacOSX Snow Leopard 10.6 cedar opt test web-platform-tests
Rev5 MacOSX Mavericks 10.9 cedar debug test web-platform-tests
Rev5 MacOSX Mavericks 10.9 cedar opt test web-platform-tests
Rev5 MacOSX Mountain Lion 10.8 cedar debug test web-platform-tests
Rev5 MacOSX Mountain Lion 10.8 cedar opt test web-platform-tests
Ubuntu ASAN VM 12.04 x64 cedar opt test web-platform-tests
Ubuntu VM 12.04 cedar debug test web-platform-tests
Ubuntu VM 12.04 cedar opt test web-platform-tests
Ubuntu VM 12.04 x64 cedar debug test web-platform-tests
Ubuntu VM 12.04 x64 cedar opt test web-platform-tests

James, do you have any preference as to the TBPL symbol used for this job? (see the help menu on TBPL for the current symbol list)
Flags: needinfo?(james)
Would wpt work?
Flags: needinfo?(james)
Yeah that sounds great :-)
Attachment #8378272 - Flags: review?(ryanvm)
Comment on attachment 8378272 [details] [diff] [review]
Add support for web-platform-tests

Review of attachment 8378272 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with comments

::: js/Config.js
@@ +421,5 @@
>      "Gaia Integration Test" : "Gi",
>      "Gaia UI Test" : "Gu",
>      "Gaia Unit Test" : "G",
>      "XPCShellTest" : "X",
> +    "W3C Web Platform Tests" : "wpt",

At a minimum, we should probably be Wpt for consistency's sake with other top-level tests. But honestly, W isn't in use, so can we just go with that?

@@ +426,1 @@
>      "Android x86 Test Combos" : "Sets", 

Kill the trailing whitespace while you're here?
Attachment #8378272 - Flags: review?(ryanvm) → review+
Depends on: 976169
In production :)
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Product: Webtools → Tree Management
Product: Tree Management → Tree Management Graveyard
You need to log in before you can comment on or make changes to this bug.