Closed
Bug 974413
Opened 10 years ago
Closed 10 years ago
Notification prompts result in empty lower margin in content
Categories
(Firefox for Metro Graveyard :: Browser, defect, P1)
Tracking
(firefox28 verified, firefox29 verified, firefox30 verified, b2g-v1.3 fixed)
VERIFIED
FIXED
Firefox 30
People
(Reporter: jimm, Assigned: sfoster)
References
Details
(Keywords: polish, Whiteboard: p=3 s=it-30c-29a-28b.3 r=ff30)
Attachments
(2 files)
205 bytes,
text/html
|
Details | |
1.98 KB,
patch
|
mbrubeck
:
review+
|
Details | Diff | Splinter Review |
str: 1) open the test case 2) enter some text and hit return 3) dismiss the save password and nav bar result: blank white margin on the bottom of the content window.
Updated•10 years ago
|
Blocks: metrobacklog
Reporter | ||
Comment 1•10 years ago
|
||
alternate str: visit a geo location page, once the prompt shows up, hit the back button.
Reporter | ||
Updated•10 years ago
|
Blocks: 967793
Summary: Save password prompts result in empty lower margin in content → Notification prompts result in empty lower margin in content
Reporter | ||
Updated•10 years ago
|
Assignee: nobody → sfoster
QA Contact: sfoster
Updated•10 years ago
|
Priority: P3 → P1
Whiteboard: [triage] → p=0
Updated•10 years ago
|
Whiteboard: p=0 → p=3
Updated•10 years ago
|
Status: NEW → ASSIGNED
QA Contact: kamiljoz
Whiteboard: p=3 → p=3 s=it-30c-29a-28b.3 r=ff30
Assignee | ||
Comment 3•10 years ago
|
||
The patch fixes the immediate issue for me, and tests pass as-is. I have a more extensive patch going onto bug 967793 which builds on this and adds further tests
Attachment #8385672 -
Flags: review?(mbrubeck)
Updated•10 years ago
|
Attachment #8385672 -
Flags: review?(mbrubeck) → review+
Assignee | ||
Comment 4•10 years ago
|
||
On fx-team: https://hg.mozilla.org/integration/fx-team/rev/a15d450783c3
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a15d450783c3
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 30
Comment 6•10 years ago
|
||
For testing and verification. Reopen if any defects found.
Flags: needinfo?(kamiljoz)
Comment 7•10 years ago
|
||
Looks like this got landed on beta even though it never had approval?! https://hg.mozilla.org/releases/mozilla-beta/rev/f232abbf5495
status-firefox28:
--- → fixed
status-firefox29:
--- → affected
status-firefox30:
--- → fixed
Flags: needinfo?(sfoster)
Assignee | ||
Comment 8•10 years ago
|
||
Ryan, yeah sorry I had it rolled up into that other patch. I should have called it out and requested separate approval
Flags: needinfo?(sfoster)
Assignee | ||
Comment 9•10 years ago
|
||
Or, duped it and moved the patch into bug 967793, which might have been clearer with hindsight
Updated•10 years ago
|
Updated•10 years ago
|
status-b2g-v1.3:
--- → fixed
Comment 11•10 years ago
|
||
Verified as fixed with Firefox 28 beta 9, latest Nightly & Aurora on a Win 8.1 x64 computer.
Status: RESOLVED → VERIFIED
Keywords: verifyme
Updated•10 years ago
|
Flags: needinfo?(kamiljoz)
You need to log in
before you can comment on or make changes to this bug.
Description
•