Closed Bug 974413 Opened 7 years ago Closed 6 years ago

Notification prompts result in empty lower margin in content

Categories

(Firefox for Metro Graveyard :: Browser, defect, P1)

x86_64
Windows 8.1
defect

Tracking

(firefox28 verified, firefox29 verified, firefox30 verified, b2g-v1.3 fixed)

VERIFIED FIXED
Firefox 30
Tracking Status
firefox28 --- verified
firefox29 --- verified
firefox30 --- verified
b2g-v1.3 --- fixed

People

(Reporter: jimm, Assigned: sfoster)

References

Details

(Keywords: polish, Whiteboard: p=3 s=it-30c-29a-28b.3 r=ff30)

Attachments

(2 files)

Attached file password.html
str:

1) open the test case
2) enter some text and hit return
3) dismiss the save password and nav bar

result: blank white margin on the bottom of the content window.
alternate str:

visit a geo location page, once the prompt shows up, hit the back button.
Blocks: 967793
Summary: Save password prompts result in empty lower margin in content → Notification prompts result in empty lower margin in content
Working on this in conjunction with bug 967793
QA Contact: sfoster
Assignee: nobody → sfoster
QA Contact: sfoster
Priority: P3 → P1
Whiteboard: [triage] → p=0
Whiteboard: p=0 → p=3
Status: NEW → ASSIGNED
QA Contact: kamiljoz
Whiteboard: p=3 → p=3 s=it-30c-29a-28b.3 r=ff30
The patch fixes the immediate issue for me, and tests pass as-is. I have a more extensive patch going onto bug 967793 which builds on this and adds further tests
Attachment #8385672 - Flags: review?(mbrubeck)
Attachment #8385672 - Flags: review?(mbrubeck) → review+
https://hg.mozilla.org/mozilla-central/rev/a15d450783c3
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 30
For testing and verification.  Reopen if any defects found.
Flags: needinfo?(kamiljoz)
Looks like this got landed on beta even though it never had approval?!
https://hg.mozilla.org/releases/mozilla-beta/rev/f232abbf5495
Flags: needinfo?(sfoster)
Ryan, yeah sorry I had it rolled up into that other patch. I should have called it out and requested separate approval
Flags: needinfo?(sfoster)
Or, duped it and moved the patch into bug 967793, which might have been clearer with hindsight
Keywords: verifyme
Verified as fixed with Firefox 28 beta 9, latest Nightly & Aurora on a Win 8.1 x64 computer.
Flags: needinfo?(kamiljoz)
You need to log in before you can comment on or make changes to this bug.