974434 - Add support for items with variable height in PanelGridView

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Awesomescreen, defect, P2)

Description

[Lucas Rocha (:lucasr)]

Stock GridView doesn't deal with them very well, the layout gets all broken as you scroll. We'll have to customize GridView somehow.

Comment 1

[Lucas Rocha (:lucasr)]

Just a quick update here:

Turns out GridView is pretty dumb about rows containing items with variable heights. It simply takes the last (or the first, if it's filling from bottom) child in the row as a reference view to define where to place the next (or previous) row. See:

https://github.com/android/platform_frameworks_base/blob/kitkat-release/core/java/android/widget/GridView.java#L357
https://github.com/android/platform_frameworks_base/blob/kitkat-release/core/java/android/widget/GridView.java#L294
https://github.com/android/platform_frameworks_base/blob/kitkat-release/core/java/android/widget/GridView.java#L391

Comment 2

[:Margaret Leibovic]

Setting P2 hub bugs to block hub v2 EPIC bug (targeting fx31 release).

Filter on epic-hub-bugs.

Comment 3

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.