974504 - sync tabs from other devices fails upon first sync now

Status: RESOLVED WORKSFORME

(Firefox :: Sync, defect, P2)

Description

[Edwin Wong [:edwong]]

Attachment: sync-err.txt

1. launch two profiles of nightly with 
username: [e-mail]
password: john01john01
2. on profile A, create a few tabs, select sync now
3. on profile B, create a few tabs, select sync now
4. view 'tabs from other devices' on both profiles.

actual: nothing displays
if i hit 'sync now' again - tabs display
profile A threw an error the first time but profile B did not.

Comment 1

[Richard Newman [:rnewman]]

This error log is from you quitting the browser half-way through it syncing history. Wrong log? Can you repro if you wait for the sync to finish?

about:sync-tabs tries to sync when it's loaded. If the browser is already syncing, nothing will happen. about:sync-tabs sucks.

Comment 2

[Edwin Wong [:edwong]]

I went through the steps again, and waiting a minute or two between each action.  When I select 'tabs from other devices' my about:sync-log fails to display any new success or error log files.  

This means two things:
* we're not firing off a sync when I load about:sync-tabs.
* we're not syncing tab data from the prior sync now command

I've also made certain that all data types are syncing in my prefs

Comment 3

[Edwin Wong [:edwong]]

Tracy is going to give this a try, just in case I'm going crazy

Comment 4

[Tracy Walker [:tracy]]

(In reply to Edwin Wong [:edwong] from comment #2)
> I went through the steps again, and waiting a minute or two between each
> action.  When I select 'tabs from other devices' my about:sync-log fails to
> display any new success or error log files.  
> 
> This means two things:
> * we're not firing off a sync when I load about:sync-tabs.
Opening TFOD is not supposed to trigger a sync

> * we're not syncing tab data from the prior sync now command
> 

I can not reproduce this with my test account.

If I:
1) open a unique page in a new Tab on Client A. Sync Now that client.
2) Sync Now Client B
3) Open History > Tabs From Other Devices

I get the expected page listed under the expected device in about:sync-tabs

Comment 5

[Tracy Walker [:tracy]]

correction, it does trigger a sync opening TFOD.  I was able to sync tabs in using that method instead of Sync Now.

Comment 6

[Richard Newman [:rnewman]]

about:sync-tabs kinda sucks. See Bug 691232, which aimed to alter the sync-forcing part, and the meta bug Bug 821020.

The patch from the former might be able to be resurrected and could help here.

Comment 7

[Edwin Wong [:edwong]]

:Tracy - I'm currently never able to get anything to display in TFOD with 2 profiles of different names on the same computer.

Peter also can repro this.

I see it upload but not pulling it down:
Profile A:
1393548838010	Sync.Engine.Tabs	INFO	1 outgoing items pre-reconciliation
1393548838286	Sync.Collection	DEBUG	mesg: GET success 200 https://sync-1-us-east-1.sync.services.mozilla.com/1.5/61499/storage/tabs?newer=1393548764.77&full=1
1393548838286	Sync.Collection	DEBUG	GET success 200 https://sync-1-us-east-1.sync.services.mozilla.com/1.5/61499/storage/tabs?newer=1393548764.77&full=1
1393548838287	Sync.Engine.Tabs	INFO	Records: 0 applied, 0 successfully, 0 failed to apply, 0 newly failed to apply, 0 reconciled.

Profile B:
1393548841055	Sync.Engine.Tabs	INFO	1 outgoing items pre-reconciliation
1393548841333	Sync.Collection	DEBUG	mesg: GET success 200 https://sync-1-us-east-1.sync.services.mozilla.com/1.5/61499/storage/tabs?newer=1393548156.11&full=1
1393548841333	Sync.Collection	DEBUG	GET success 200 https://sync-1-us-east-1.sync.services.mozilla.com/1.5/61499/storage/tabs?newer=1393548156.11&full=1
1393548841334	Sync.Engine.Tabs	INFO	Records: 0 applied, 0 successfully, 0 failed to apply, 0 newly failed to apply, 0 reconciled.
1393548841339	Sync.Engine.Tabs	INFO	Uploading all of 1 records

Comment 8

[Edwin Wong [:edwong]]

I'm not able to repro this as of now.  Closing