Closed
Bug 974540
Opened 12 years ago
Closed 12 years ago
nsMemoryReporterManager's count of child processes is wrong when Nuwa is enabled
Categories
(Toolkit :: about:memory, defect)
Tracking
()
RESOLVED
FIXED
mozilla30
People
(Reporter: jld, Assigned: jld)
References
Details
(Whiteboard: [MemShrink])
Attachments
(1 file, 1 obsolete file)
|
3.08 KB,
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
If Nuwa is enabled, the nsMemoryReporterManager's count of child processes will include Nuwa but not Nuwa's children, which is exactly the opposite of what's supposed to happen. This means that the count is (usually?) always 1, which causes only the first child to respond to be included in the report.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #8378450 -
Flags: review?(khuey)
|
||
Updated•12 years ago
|
Whiteboard: [MemShrink]
Comment on attachment 8378450 [details] [diff] [review]
bug974540-memchild-nuwa-count-hg0.diff
Review of attachment 8378450 [details] [diff] [review]:
-----------------------------------------------------------------
If the Nuwa process is ever killed and reborn the number here will get out of sync.
Attachment #8378450 -
Flags: review?(khuey) → review-
|
|
Assignee | |
Comment 3•12 years ago
|
||
The fix is simple. Tested by manually SIGKILL'ing Nuwa a few times.
Attachment #8378450 -
Attachment is obsolete: true
Attachment #8383389 -
Flags: review?(khuey)
Attachment #8383389 -
Flags: review?(khuey) → review+
|
|
Assignee | |
Updated•12 years ago
|
Keywords: checkin-needed
|
||
Comment 4•12 years ago
|
||
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in
before you can comment on or make changes to this bug.
Description
•