disable goog-white-digest256 on non-windows platforms

RESOLVED FIXED in Firefox 30

Status

()

Toolkit
Safe Browsing
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: mmc, Assigned: mmc)

Tracking

unspecified
Firefox 30
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

https://bugzilla.mozilla.org/show_bug.cgi?id=964465#c20
Assignee: nobody → mmc
Created attachment 8382363 [details] [diff] [review]
Disable goog-white-digest256 for non-windows (
Comment on attachment 8382363 [details] [diff] [review]
Disable goog-white-digest256 for non-windows (

Review of attachment 8382363 [details] [diff] [review]:
-----------------------------------------------------------------

Note that urlclassifier.download_block_table and download_allow_table are blank on non-desktop applications, so we just need to turn off white-digest256 for non-windows on desktop.

This patch also prefs on application reputation local checks in Nightly. If you want, I can file a separate bug for that and split this patch in two.
Attachment #8382363 - Flags: review?(gpascutto)
Attachment #8382363 - Flags: review?(gpascutto) → review+
Blocks: 662819
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/9d58d9a2c8b1
https://hg.mozilla.org/mozilla-central/rev/9d58d9a2c8b1
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 30
https://hg.mozilla.org/mozilla-central/rev/9d58d9a2c8b1#l1.13

Shouldn't that '&' be a '?' ?
(In reply to Reed Loden [:reed] from comment #5)
> https://hg.mozilla.org/mozilla-central/rev/9d58d9a2c8b1#l1.13
> 
> Shouldn't that '&' be a '?' ?

Yes, it should. This works when I test manually, but we should fix it anyway.
Blocks: 977663

Updated

3 years ago
QA Whiteboard: [qa-]
Component: Phishing Protection → Phishing Protection
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.