Closed
Bug 974579
Opened 11 years ago
Closed 11 years ago
disable goog-white-digest256 on non-windows platforms
Categories
(Toolkit :: Safe Browsing, defect)
Tracking
()
RESOLVED
FIXED
Firefox 30
People
(Reporter: mmc, Assigned: mmc)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
2.65 KB,
patch
|
gcp
:
review+
|
Details | Diff | Splinter Review |
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → mmc
|
|
Assignee | |
Comment 1•11 years ago
|
||
|
|
Assignee | |
Comment 2•11 years ago
|
||
Comment on attachment 8382363 [details] [diff] [review]
Disable goog-white-digest256 for non-windows (
Review of attachment 8382363 [details] [diff] [review]:
-----------------------------------------------------------------
Note that urlclassifier.download_block_table and download_allow_table are blank on non-desktop applications, so we just need to turn off white-digest256 for non-windows on desktop.
This patch also prefs on application reputation local checks in Nightly. If you want, I can file a separate bug for that and split this patch in two.
Attachment #8382363 -
Flags: review?(gpascutto)
|
||
Updated•11 years ago
|
Attachment #8382363 -
Flags: review?(gpascutto) → review+
|
|
Assignee | |
Updated•11 years ago
|
Blocks: downloadprotection
|
|
Assignee | |
Comment 3•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 30
|
||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9d58d9a2c8b1#l1.13
Shouldn't that '&' be a '?' ?
|
|
Assignee | |
Comment 6•11 years ago
|
||
(In reply to Reed Loden [:reed] from comment #5)
> https://hg.mozilla.org/mozilla-central/rev/9d58d9a2c8b1#l1.13
>
> Shouldn't that '&' be a '?' ?
Yes, it should. This works when I test manually, but we should fix it anyway.
|
||
Updated•11 years ago
|
QA Whiteboard: [qa-]
|
||
Updated•11 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•