Closed Bug 974579 Opened 6 years ago Closed 6 years ago

disable goog-white-digest256 on non-windows platforms

Categories

(Toolkit :: Safe Browsing, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 30

People

(Reporter: mmc, Assigned: mmc)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Assignee: nobody → mmc
Comment on attachment 8382363 [details] [diff] [review]
Disable goog-white-digest256 for non-windows (

Review of attachment 8382363 [details] [diff] [review]:
-----------------------------------------------------------------

Note that urlclassifier.download_block_table and download_allow_table are blank on non-desktop applications, so we just need to turn off white-digest256 for non-windows on desktop.

This patch also prefs on application reputation local checks in Nightly. If you want, I can file a separate bug for that and split this patch in two.
Attachment #8382363 - Flags: review?(gpascutto)
Attachment #8382363 - Flags: review?(gpascutto) → review+
https://hg.mozilla.org/mozilla-central/rev/9d58d9a2c8b1
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 30
(In reply to Reed Loden [:reed] from comment #5)
> https://hg.mozilla.org/mozilla-central/rev/9d58d9a2c8b1#l1.13
> 
> Shouldn't that '&' be a '?' ?

Yes, it should. This works when I test manually, but we should fix it anyway.
QA Whiteboard: [qa-]
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.