974598 - Handle full refreshes from locale changes immediately in HomeConfigInvalidator

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Lucas Rocha (:lucasr)]

Right now, there's a visible delay between the locale change and the UI update.

Comment 1

[Lucas Rocha (:lucasr)]

Attachment: Handle locale changes immediately in HomeConfigInvalidator (r=margaret)

Comment 2

[Lucas Rocha (:lucasr)]

Comment on attachment 8379007 [details] [diff] [review]
Handle locale changes immediately in HomeConfigInvalidator (r=margaret)

Reduces the delay between the locale change and HomePager update.

Comment 3

[Lucas Rocha (:lucasr)]

Attachment: Handle locale changes immediately in HomeConfigInvalidator (r=margaret)

Comment 4

[Lucas Rocha (:lucasr)]

Comment on attachment 8379168 [details] [diff] [review]
Handle locale changes immediately in HomeConfigInvalidator (r=margaret)

This updated patch is a complement to the new one in bug 972306. It separates UPDATE from REFRESH (which now mean different things) and runs refreshes triggered by locale changes immediately.

Comment 5

[:Margaret Leibovic]

Comment on attachment 8379168 [details] [diff] [review]
Handle locale changes immediately in HomeConfigInvalidator (r=margaret)

Review of attachment 8379168 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

::: mobile/android/base/home/HomeConfigInvalidator.java
@@ -85,5 @@
>              @Override
>              public void run() {
>                  final String configLocale = mHomeConfig.getLocale();
>                  if (!TextUtils.equals(configLocale, locale)) {
> -                    handlePanelUpdate(null);

I like getting rid of this null parameter usage.

@@ +245,5 @@
>                      break;
>                  }
> +
> +                case REFRESH: {
> +                    shouldRefresh = true;

Nice, I like how this is more explicit now.

Comment 6

[Lucas Rocha (:lucasr)]

https://hg.mozilla.org/integration/fx-team/rev/cc947666b4ed

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/cc947666b4ed