Closed Bug 974598 Opened 10 years ago Closed 10 years ago

Handle full refreshes from locale changes immediately in HomeConfigInvalidator

Categories

(Firefox for Android Graveyard :: Awesomescreen, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 30

People

(Reporter: lucasr, Assigned: lucasr)

References

Details

Attachments

(1 file, 1 obsolete file)

Right now, there's a visible delay between the locale change and the UI update.
Comment on attachment 8379007 [details] [diff] [review]
Handle locale changes immediately in HomeConfigInvalidator (r=margaret)

Reduces the delay between the locale change and HomePager update.
Attachment #8379007 - Flags: review?(margaret.leibovic)
Attachment #8379007 - Attachment is obsolete: true
Attachment #8379007 - Flags: review?(margaret.leibovic)
Comment on attachment 8379168 [details] [diff] [review]
Handle locale changes immediately in HomeConfigInvalidator (r=margaret)

This updated patch is a complement to the new one in bug 972306. It separates UPDATE from REFRESH (which now mean different things) and runs refreshes triggered by locale changes immediately.
Attachment #8379168 - Flags: review?(margaret.leibovic)
Comment on attachment 8379168 [details] [diff] [review]
Handle locale changes immediately in HomeConfigInvalidator (r=margaret)

Review of attachment 8379168 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

::: mobile/android/base/home/HomeConfigInvalidator.java
@@ -85,5 @@
>              @Override
>              public void run() {
>                  final String configLocale = mHomeConfig.getLocale();
>                  if (!TextUtils.equals(configLocale, locale)) {
> -                    handlePanelUpdate(null);

I like getting rid of this null parameter usage.

@@ +245,5 @@
>                      break;
>                  }
> +
> +                case REFRESH: {
> +                    shouldRefresh = true;

Nice, I like how this is more explicit now.
Attachment #8379168 - Flags: review?(margaret.leibovic) → review+
https://hg.mozilla.org/mozilla-central/rev/cc947666b4ed
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 30
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: