[PATCH]Print will crash with printer thats not ready

VERIFIED FIXED in mozilla0.9.5

Status

()

VERIFIED FIXED
18 years ago
17 years ago

People

(Reporter: dcone, Assigned: dcone)

Tracking

({topembed})

Trunk
mozilla0.9.5
x86
Windows NT
topembed
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments)

(Assignee)

Description

18 years ago
If you print.. and dont have a driver.. or get a null string back from the 
printer, if the printer is not ready, you get a crash.
(Assignee)

Comment 1

18 years ago
Created attachment 47490 [details] [diff] [review]
Checks for the devnames before preceding with print
(Assignee)

Comment 2

18 years ago
there are some formating changes.. so the patch seems large, but its really not.  
The thing to look for is the new line

if (0 != devnames){

}

Comment 3

18 years ago
Don, could you attach a patch with no whitespace changes (cvs diff -u -w will do
it) - thanks.
(Assignee)

Comment 4

18 years ago
Created attachment 47502 [details] [diff] [review]
here is a patch with all the whitespace out

Comment 5

18 years ago
Thansk Don - SR=attinasi

Comment 6

18 years ago
wouldn't it be better to use PR_TRUE and nsnull?
(Assignee)

Comment 7

18 years ago
I dont think so.  I am checking a value returned from a windows call, which 
returns true or false.. PR_TRUE is a Netscape value.. and we can define those 
anyway we want..for our own calls.  Also.. that is not part of the patch.
The 0 is also a value returned by a windows call.. nsnull is not guarenteed to 
be 0, its just a value to check against Netscape calls. I believe that is the 
correct way to use these values.
(Assignee)

Updated

18 years ago
Summary: Print will crash with printer thats not ready → [PATCH]Print will crash with printer thats not ready

Comment 8

18 years ago
r=rods, but change the 0 to NULL because that's what the documentation says the 
value could come back as.
(Assignee)

Updated

18 years ago
Target Milestone: --- → mozilla0.9.4
(Assignee)

Comment 9

18 years ago
This is a crasher.. so marking as topembed.
Keywords: topembed
(Assignee)

Comment 10

18 years ago
Created attachment 47800 [details] [diff] [review]
New patch that changes the 0 to NULL
(Assignee)

Comment 11

18 years ago
Created attachment 47801 [details] [diff] [review]
correct patch

Comment 12

18 years ago
a=chofmann for 0.9.4
Set milestone to mozilla0.9.5 added nsbranch keyword
Keywords: nsbranch
Target Milestone: mozilla0.9.4 → mozilla0.9.5
(Assignee)

Comment 14

18 years ago
this is checked into the 9.4 branch.
Keywords: nsbranch
(Assignee)

Comment 15

18 years ago
Checked into the 9.2 branch also
Status: NEW → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED

Comment 16

17 years ago
verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.