97461 - [PATCH]Print will crash with printer thats not ready

Status: VERIFIED FIXED

(Core :: Printing: Output, defect)

Description

[dcone (gone)]

If you print.. and dont have a driver.. or get a null string back from the 
printer, if the printer is not ready, you get a crash.

Comment 1

[dcone (gone)]

Attachment: Checks for the devnames before preceding with print

Comment 2

[dcone (gone)]

there are some formating changes.. so the patch seems large, but its really not.  
The thing to look for is the new line

if (0 != devnames){

}

Comment 3

[Marc Attinasi]

Don, could you attach a patch with no whitespace changes (cvs diff -u -w will do
it) - thanks.

Comment 4

[dcone (gone)]

Attachment: here is a patch with all the whitespace out

Comment 5

[Marc Attinasi]

Thansk Don - SR=attinasi

Comment 6

[Bernd]

wouldn't it be better to use PR_TRUE and nsnull?

Comment 7

[dcone (gone)]

I dont think so.  I am checking a value returned from a windows call, which 
returns true or false.. PR_TRUE is a Netscape value.. and we can define those 
anyway we want..for our own calls.  Also.. that is not part of the patch.
The 0 is also a value returned by a windows call.. nsnull is not guarenteed to 
be 0, its just a value to check against Netscape calls. I believe that is the 
correct way to use these values.

Comment 8

[rods (gone)]

r=rods, but change the 0 to NULL because that's what the documentation says the 
value could come back as.

Comment 9

[dcone (gone)]

This is a crasher.. so marking as topembed.

Comment 10

[dcone (gone)]

Attachment: New patch that changes the 0 to NULL

Comment 11

[dcone (gone)]

Attachment: correct patch

Comment 12

[chris hofmann]

a=chofmann for 0.9.4

Comment 13

[Kevin McCluskey (gone)]

Set milestone to mozilla0.9.5 added nsbranch keyword

Comment 14

[dcone (gone)]

this is checked into the 9.4 branch.

Comment 15

[dcone (gone)]

Checked into the 9.2 branch also

Comment 16

[sujay]

verified.