974641 - Favicon for in-content preferences

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Zhenshuo Fang (:fang) - Firefox UX Team]

We need a favicon for in-content preferences. We can use the gear icon from here http://people.mozilla.org/~shorlander/drops/australis-toolbar-and-menuPanel-icons/

Comment 1

[Florian Bender]

Why not use the Firefox icon + text used in all in-content pages (e.g. about:home)? Reusing that for the favicon would be great for consistency.

Comment 2

[u428464]

(In reply to Florian Bender from comment #1)
> Why not use the Firefox icon + text used in all in-content pages (e.g.
> about:home)? Reusing that for the favicon would be great for consistency.

Are you talking about the identity block ? Because concerning the favicons, I think exactly the opposite. Each in-content page should have its own favicon. The firefox favicon is used on website too it's not a good idea to use for browser pages.

Comment 3

[Florian Bender]

Ah yes, I was talking about the identity block. The favicon (in the tab bar) can be something else, though I'd still prefer to use the Firefox icon (for consistency's sake). Whatever favicon you choose here will be used by websites anyway (at least the shady ones).

Comment 4

[u428464]

It should be nice to have a real favicon and not just the spritesheet.

Comment 5

[Michael Maslaney [:mmaslaney] ([e-mail])]

I'll take this one.

Comment 6

[Michael Maslaney [:mmaslaney] ([e-mail])]

Attachment: inContent-Favicon.png

Comment 7

[Michael Maslaney [:mmaslaney] ([e-mail])]

Attachment: [e-mail]

Comment 8

[u428464]

Could this bug be nominated for the backlog ?

Comment 9

[Hernán Rodriguez Colmeiro (:peregrino)]

I'm taking this one

Comment 10

[Hernán Rodriguez Colmeiro (:peregrino)]

So, this can be solved by adding a <link rel="icon"> to the about:preferences page, but then we have the issue of the HiDPI devices. That can be solved for free if we use an .ico file with both resolutions, but who should I ask for that file?

Comment 11

[Matthew N. [:MattN]]

(In reply to Hernán Rodriguez Colmeiro (:peregrino) from comment #10)
> So, this can be solved by adding a <link rel="icon"> to the
> about:preferences page, but then we have the issue of the HiDPI devices.
> That can be solved for free if we use an .ico file with both resolutions,
> but who should I ask for that file?

Hello,

You can make it yourself using http://frankyan.com/labs/ico/

Cheers

Comment 12

[Hernán Rodriguez Colmeiro (:peregrino)]

Attachment: proposed patch

Proposed patch, includes an ico file with both resolutions.

Comment 13

[Hernán Rodriguez Colmeiro (:peregrino)]

Attachment: proposed patch

Oops, forgot windows, sorry.

Comment 14

[Jared Wein [:jaws] (please needinfo? me)]

I tested that the regular and HiDPI icons work.

Comment 15

[Frank Yan (:fryn)]

(In reply to Matthew N. [:MattN] from comment #11)
> You can make it yourself using http://frankyan.com/labs/ico/

Just wanted to say that it is super awesome that you guys found this to be useful!
I just updated the code a week ago so that it uses the latest File and Blob APIs. :)

Comment 16

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Frank Yan (:fryn) from comment #15)
> (In reply to Matthew N. [:MattN] from comment #11)
> > You can make it yourself using http://frankyan.com/labs/ico/
> 
> Just wanted to say that it is super awesome that you guys found this to be
> useful!
> I just updated the code a week ago so that it uses the latest File and Blob
> APIs. :)

\o/

Comment 17

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/e6f7ca79cc8a

Comment 18

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e6f7ca79cc8a