Closed
Bug 974652
Opened 11 years ago
Closed 11 years ago
Add aWidgetId and aArea to INFO()'d message when failing in onWidgetRemoved
Categories
(Firefox :: Toolbars and Customization, defect)
Tracking
()
RESOLVED
FIXED
Firefox 33
People
(Reporter: quicksaver, Assigned: rittme, Mentored)
References
(Blocks 1 open bug)
Details
(Whiteboard: [Australis:P5][good first bug][lang=js])
Attachments
(1 file)
|
1.18 KB,
patch
|
MattN
:
review+
|
Details | Diff | Splinter Review |
Here: http://mxr.mozilla.org/mozilla-central/source/browser/components/customizableui/src/CustomizableUI.jsm#730
Personally, my add-on(s) seem to be triggering that message very often when disabled, but all the widgets they insert are removed correctly (and it doesn't trigger it on every widget, in fact it's quite random the amount/frequency with which that message appears).
I can't figure out what widget/action is causing that message exactly, not even by keeping track of every on* event that CUI dispatches (weird, right?!). The ID of the widget in that message would go a long way.
|
Reporter | |
Comment 1•11 years ago
|
||
Also perhaps the aArea parameter passed as well? Something like "Widget aWidgetId not found, unable to remove from aArea".
|
||
Comment 2•11 years ago
|
||
This should just add the relevant strings into the message in the code linked in comment #0.
Blocks: australis-cust
Whiteboard: [Australis:P5][mentor=Gijs][lang=js]
|
||
Updated•11 years ago
|
|
|
||
Updated•11 years ago
|
Whiteboard: [Australis:P5][mentor=Gijs][lang=js] → [Australis:P5][good first bug][mentor=Gijs][lang=js]
|
||
Updated•11 years ago
|
Mentor: gijskruitbosch+bugs
Whiteboard: [Australis:P5][good first bug][mentor=Gijs][lang=js] → [Australis:P5][good first bug][lang=js]
|
||
Comment 3•11 years ago
|
||
Updated code link: http://mxr.mozilla.org/mozilla-central/source/browser/components/customizableui/src/CustomizableUI.jsm?rev=d93b579522fd#785
Assignee: nobody → bernardo
Status: NEW → ASSIGNED
|
Assignee | |
Comment 4•11 years ago
|
||
I think this should do it.
Attachment #8449014 -
Flags: review?(MattN+bmo)
|
|
||
Comment 5•11 years ago
|
||
Comment on attachment 8449014 [details] [diff] [review]
rev 1 - changed INFO to contain relevant strings
Thanks, looks good!
Attachment #8449014 -
Flags: review?(MattN+bmo) → review+
|
|
||
Comment 6•11 years ago
|
||
The logging-only change shouldn't require a Try push.
Keywords: checkin-needed
|
|
||
Comment 7•11 years ago
|
||
The bug summary can be used as the commit message:
"Bug 974652 - Add aWidgetId and aArea to INFO()'d message when failing in onWidgetRemoved. r=MattN"
Summary: Australis debug suggestion: add aWidgetId to INFO()'d message when failing to remove widget → Add aWidgetId and aArea to INFO()'d message when failing in onWidgetRemoved
|
||
Comment 8•11 years ago
|
||
Keywords: checkin-needed
Whiteboard: [Australis:P5][good first bug][lang=js] → [Australis:P5][good first bug][lang=js][fixed-in-fx-team]
|
|
||
Comment 9•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P5][good first bug][lang=js][fixed-in-fx-team] → [Australis:P5][good first bug][lang=js]
Target Milestone: --- → Firefox 33
You need to log in
before you can comment on or make changes to this bug.
Description
•