974757 - [Flatfish] Fail to backup /system by extract-files.sh

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Danny Liang [:dliang]]

In flatfish, it's fail to backup /system due to DEVICE_BUILD_ID is not match in extract-files.sh

Comment 1

[Danny Liang [:dliang]]

Attachment: pull request for bug 974757

Comment 2

[Kai-Zhen Li [:seinlin][:kli]]

Comment on attachment 8378802 [details] [review]
pull request for bug 974757

It does work. DEVICE_BUILD_ID could be flatfish* or full_flatfish*, this can make sure files can be extracted successfully from devices.

Marco, can you help to review it? Thanks!

Comment 3

[Kai-Zhen Li [:seinlin][:kli]]

Comment on attachment 8378802 [details] [review]
pull request for bug 974757

Additional information, ro.build.display.id in firmware of developer version is "flatfish-eng*"; In frimware configured and built from mozilla-b2g/B2G, ro.build.display.id will be "full_flatfish-eng*".
So we'll need this patch in order to extract the files successfully from devices no matter which firmware version is used.

Comment 4

[Marco Chen [:mchen]]

Q1: What is the reason of there is a different id between developer version and our own build?

Q2: What is the developer version? any other build variation for this? 
    Or you mean the first version we pre-installed into devices during manufacturer.

Comment 5

[Kai-Zhen Li [:seinlin][:kli]]

(In reply to Marco Chen [:mchen] from comment #4)
> Q1: What is the reason of there is a different id between developer version
> and our own build?
AFAIK, no special reason, but the id was hard coded in pre-installed firmware.

> Q2: What is the developer version? any other build variation for this? 
>     Or you mean the first version we pre-installed into devices during
> manufacturer.
Yes, it is the pre-installed firmware in devices for developers.

Comment 6

[Marco Chen [:mchen]]

Comment on attachment 8378802 [details] [review]
pull request for bug 974757

So in order to cover different "ro.build.display.id" in first shipped image (made for manufacturer) and the one built from B2G/config.sh, we need to support these two naming. Thanks for your explanation.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Master: 05a3ca4ad3dec40e13548109dfd096134d81cdaf