Closed Bug 974757 Opened 9 years ago Closed 9 years ago

[Flatfish] Fail to backup /system by extract-files.sh

Categories

(Firefox OS Graveyard :: General, defect)

Product:
Firefox OS Graveyard
Component:
General
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v1.4 fixed)

Status:
RESOLVED FIXED
Milestone:
1.4 S3 (14mar)
Tracking Flags:
Tracking Status
b2g-v1.4 --- fixed

People

(Reporter: dliang, Assigned: dliang)

Details

Attachments

(1 file)

pull request for bug 974757
53 bytes, text/x-github-pull-request
mchen
: review+
seinlin
: feedback+
Details | Review 
In flatfish, it's fail to backup /system due to DEVICE_BUILD_ID is not match in extract-files.sh

    
  

        Attachment #8378802 -
        Flags: feedback?(kli)

    
  
Assignee: nobody → dliang

    
    

    
  
Comment on attachment 8378802 [details] [review]
pull request for bug 974757

It does work. DEVICE_BUILD_ID could be flatfish* or full_flatfish*, this can make sure files can be extracted successfully from devices.

Marco, can you help to review it? Thanks!

        Attachment #8378802 -
        Flags: review?(mchen)

        Attachment #8378802 -
        Flags: feedback?(kli)

        Attachment #8378802 -
        Flags: feedback+

    
    

    
  
Comment on attachment 8378802 [details] [review]
pull request for bug 974757

Additional information, ro.build.display.id in firmware of developer version is "flatfish-eng*"; In frimware configured and built from mozilla-b2g/B2G, ro.build.display.id will be "full_flatfish-eng*".
So we'll need this patch in order to extract the files successfully from devices no matter which firmware version is used.

    
    

    
  
Q1: What is the reason of there is a different id between developer version and our own build?

Q2: What is the developer version? any other build variation for this? 
    Or you mean the first version we pre-installed into devices during manufacturer.

    
    

    
  
(In reply to Marco Chen [:mchen] from comment #4)
> Q1: What is the reason of there is a different id between developer version
> and our own build?
AFAIK, no special reason, but the id was hard coded in pre-installed firmware.

> Q2: What is the developer version? any other build variation for this? 
>     Or you mean the first version we pre-installed into devices during
> manufacturer.
Yes, it is the pre-installed firmware in devices for developers.

    
    

    
  
Comment on attachment 8378802 [details] [review]
pull request for bug 974757

So in order to cover different "ro.build.display.id" in first shipped image (made for manufacturer) and the one built from B2G/config.sh, we need to support these two naming. Thanks for your explanation.

        Attachment #8378802 -
        Flags: review?(mchen) → review+

    
    

    
  
Master: 05a3ca4ad3dec40e13548109dfd096134d81cdaf
Status: NEW → RESOLVED
Closed: 9 years ago

          status-b2g-v1.4:
          --- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 1.4 S3 (14mar)

          You need to log in
          before you can comment on or make changes to this bug.