974771 - Currently downloading file can be attempted to open

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Download Manager, defect)

Description

[Ashish Vijayaram [:ashish]]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:29.0) Gecko/20100101 Firefox/29.0 (Beta/Release)
Build ID: 20140213004002

Steps to reproduce:

Open a large enough file for download, say an .apk. While the download is in progress, open Menu > Tools > Downloads and tap on the file.


Actual results:

Firefox attempts to open the file which unsurprisingly results in errors


Expected results:

Until the download completes, the only available actions should be Pause/Resume or Cancel

Comment 1

[Aaron Train [:aaronmt]]

I figure this will go away once we transition to the native system download application. On my Nexus 5 running Android 4.4.2, I notice that on attempt to access the in-progress download in the application nothing will happen.

Perhaps Josh with his current set of in-progress patches can verify this?

Comment 2

[Aaron Train [:aaronmt]]

I'm referencing bug 816318 in comment #1.

Comment 3

[Josh Dover [:jdover]]

Yes this won't be an issue once work on bug 816318 is finished, but this could persist on Froyo devices as they will continue to use the old download manager.

Comment 4

[Eugen Sawin [:esawin]]

Attachment: Ignore open request for unfinished download

We could simply ignore the open request, or do we want to show a warning message?
What does the system download manager do in this case, to make it consistent?

Comment 5

[Josh Dover [:jdover]]

The system download manager opens up the download list, so we could open about:downloads.

Comment 6

[Eugen Sawin [:esawin]]

Attachment: Ignore open request for unfinished download

Comment 7

[Wesley Johnston (:wesj)]

Comment on attachment 8387067 [details] [diff] [review]
Ignore open request for unfinished download

Review of attachment 8387067 [details] [diff] [review]:
-----------------------------------------------------------------

We could probably show a dialog with some options, but since this UI is dying, that's a waste of time :)

Comment 8

[Eugen Sawin [:esawin]]

Agreed, also the system download manager does not provide any options in that case either, so what we here is more or less consistent.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/c64ce8e54e04

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c64ce8e54e04