974786 - toolkit/components/downloads/ApplicationReputation.cpp:117:3: error: 'TimeStamp' does not name a type (non-SPS)

Status: RESOLVED FIXED

(Toolkit :: Downloads API, defect)

Description

[Jan Beich]

Attachment: fix

Not sure why inbound is green, maybe because I'm on non-SPS platform.

In file included from toolkit/components/downloads/Unified_cpp_toolkit_components_downloads0.cpp:2:
toolkit/components/downloads/ApplicationReputation.cpp:117:3: error:
      unknown type name 'TimeStamp'; did you mean 'mozilla::TimeStamp'?
  TimeStamp mStartTime;
  ^~~~~~~~~
  mozilla::TimeStamp
../../../dist/include/GeckoProfiler.h:56:7: note: 'mozilla::TimeStamp' declared here
class TimeStamp;
      ^
In file included from toolkit/components/downloads/Unified_cpp_toolkit_components_downloads0.cpp:2:
toolkit/components/downloads/ApplicationReputation.cpp:489:16: error:
      use of undeclared identifier 'TimeStamp'; did you mean 'mozilla::TimeStamp'?
  mStartTime = TimeStamp::Now();
               ^~~~~~~~~
               mozilla::TimeStamp
../../../dist/include/GeckoProfiler.h:56:7: note: 'mozilla::TimeStamp' declared here
class TimeStamp;
      ^
In file included from toolkit/components/downloads/Unified_cpp_toolkit_components_downloads0.cpp:28:
toolkit/components/downloads/nsDownloadManager.cpp:110:5: warning:
      'g_type_init' is deprecated [-Wdeprecated-declarations]
    g_type_init();
    ^
/usr/local/include/glib-2.0/gobject/gtype.h:669:23: note: 'g_type_init' has been
      explicitly marked deprecated here
void                  g_type_init                    (void);
                      ^
1 warning and 2 errors generated.

Comment 1

[Jan Beich]

Another non-SPS platform hit the error:
http://mozillaproject.osuosl.org:8010/builders/runtests/builds/1004/steps/shell/logs/stdio

Landry, do you see it too?

Comment 2

[[:mmc] Monica Chew (no longer reading bugmail)]

Comment on attachment 8378819 [details] [diff] [review]
fix

Review of attachment 8378819 [details] [diff] [review]:
-----------------------------------------------------------------

It's very strange that this triggered a platform-specific error.

Comment 3

[Jan Beich]

Attachment: same fix with slightly better commit message

Adding #error shows where |using mozilla::TimeStamp| is bootlegged from

  ApplicationReputation.cpp:30:
  mozilla/Telemetry.h:11:
  StartupTimeline.h:28:
  GeckoProfiler.h:177:
  GeckoProfilerImpl.h:18:
  GeckoProfilerFunc.h:18:

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ab699ac39bd5

Comment 5

[Landry Breuil (:gaston)]

(In reply to Jan Beich from comment #1)
> Another non-SPS platform hit the error:
> http://mozillaproject.osuosl.org:8010/builders/runtests/builds/1004/steps/
> shell/logs/stdio
> 
> Landry, do you see it too?

I'm currently broken because of #973310, so cant say..

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ab699ac39bd5