Closed Bug 974891 Opened 6 years ago Closed 6 years ago

Move TestCapabilities to test_capabilities.py file

Categories

(Testing :: Marionette, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla30

People

(Reporter: ato, Assigned: mishravikas)

Details

Attachments

(1 file, 2 obsolete files)

The TestCapabilities class currently sits in test_session.py.  It should be moved to test_capabilities.py for consistency.
I would like to work in this bug
Excellent!

There is already a test in test_capabilities.py, but this is superseded by the more mature tests from the TestCapabilities class in test_session.py.
Attached patch mypatch.patch (obsolete) — Splinter Review
Moved TestCapabilities class to test_capabilities.py
Attachment #8391256 - Flags: review?
Attachment #8391256 - Flags: review? → review?(ato)
Assignee: nobody → vikasmishra95
Attached patch New Patch (obsolete) — Splinter Review
Attachment #8391338 - Flags: review?(jgriffin)
Attachment #8391338 - Flags: review?(jgriffin) → review?(ato)
Attachment #8391256 - Attachment is obsolete: true
Attachment #8391256 - Flags: review?(ato)
Comment on attachment 8391338 [details] [diff] [review]
New Patch

This is good, thanks!  If you have the time, would you please also add test_capabilities.py to testing/marionette/client/marionette_tests/unit/unit-tests.ini?  It seems to be missing from there.
Attachment #8391338 - Flags: review?(ato) → review+
Flags: needinfo?(vikasmishra95)
Attachment #8391391 - Flags: review?(ato)
Flags: needinfo?(vikasmishra95)
Comment on attachment 8391391 [details] [diff] [review]
New Patch with mentioned changes

Review of attachment 8391391 [details] [diff] [review]:
-----------------------------------------------------------------

Perfect, thanks!
Attachment #8391391 - Flags: review?(ato) → review+
Keywords: checkin-needed
Attachment #8391338 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/a94de1fe002c
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.