974891 - Move TestCapabilities to test_capabilities.py file

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Andreas Tolfsen ❲:ato❳]

The TestCapabilities class currently sits in test_session.py.  It should be moved to test_capabilities.py for consistency.

Comment 1

[Vikas Mishra [:mishravikas]]

I would like to work in this bug

Comment 2

[Andreas Tolfsen ❲:ato❳]

Excellent!

There is already a test in test_capabilities.py, but this is superseded by the more mature tests from the TestCapabilities class in test_session.py.

Comment 3

[Vikas Mishra [:mishravikas]]

Attachment: mypatch.patch

Moved TestCapabilities class to test_capabilities.py

Comment 4

[Vikas Mishra [:mishravikas]]

Attachment: New Patch

Comment 5

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8391338 [details] [diff] [review]
New Patch

This is good, thanks!  If you have the time, would you please also add test_capabilities.py to testing/marionette/client/marionette_tests/unit/unit-tests.ini?  It seems to be missing from there.

Comment 6

[Vikas Mishra [:mishravikas]]

Attachment: New Patch with mentioned changes

Comment 7

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8391391 [details] [diff] [review]
New Patch with mentioned changes

Review of attachment 8391391 [details] [diff] [review]:
-----------------------------------------------------------------

Perfect, thanks!

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a94de1fe002c

Comment 9

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/mozilla-central/rev/a94de1fe002c