974897 - |make test-integration APP=< . . . >| doesn't run because it doesn't generate a good profile

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Anthony Ricaud (:rik)]

Steps To Reproduce:
rm -rf profile-test
make test-integration APP=email

Workaround:
rm -rf profile-test
make test-integration
Ctrl-C when the tests start running (aka a good profile was generated)
make test-integration APP=email

Comment 1

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

bisect done, root cause is gaia-marionette modification.

0327274616fb442de9b1146e2fb5a901d3d45d81 is the first bad commit
commit 0327274616fb442de9b1146e2fb5a901d3d45d81
Author: Dale Harvey <[e-mail]>
Date:   Fri Jan 31 11:19:21 2014 +0000

    Bug 966215 - Allow make test-integration to specify TEST_FILES. r=gaye

:100644 100644 591d426f574f4f2170e2ab274c0ead104f341157 c853f11097ced782e13c5f43088bad300fce848e M  Makefile
:100644 100644 c36e9dcb56e3b6007f65d166402358570d8812d7 cb6a7b8b94594008b728ac1943b8b27fabe7e5cc M  README.md
:040000 040000 7ae1b9e692d449dc63158d23dee18d49442a29ed e2489909887e971ab41683fb967dfb9d9730a097 M  bin

Comment 2

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Dale, could you help on this?

Comment 3

[(Inactive after June) George Duan [:gduan] [:喬智]]

Before the commit , the profile-test contains all the apps, but now we only have APP=TARGET_APP.
Most of failed tests are trying to access another app inside TARGET_APP, I believe that's the reason.

Comment 4

[Dale Harvey (:daleharvey)]

Theres 2 bugs here, BUILD_APP_NAME shouldnt be modified if we are doing test-integration, sorry that was my bad

The other seems to be some regression with passing command line args, looking at it now

Comment 5

[Dale Harvey (:daleharvey)]

heh, the email tests were on a travis blacklist which is also set to our local default

Comment 6

[Dale Harvey (:daleharvey)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/16577

I dont think we need a local default, however the way the arguments are passed here means anything else will be messy and complicated

The profile generation was a regression from https://bugzilla.mozilla.org/show_bug.cgi?id=966215, apologies

Comment 8

[Dale Harvey (:daleharvey)]

I had assumed the travis manifest got set by travis, but that was wrong, added it to the travis script and merged with a green run

https://github.com/mozilla-b2g/gaia/commit/e5cb62e63b3c2fbe326c96f712e36d228cc765ad