Open Bug 974910 Opened 6 years ago Updated 4 years ago

Controls bar is moved up for audio files played inline

Categories

(Toolkit :: Video/Audio Controls, defect)

28 Branch
defect
Not set
Points:
2

Tracking

()

Tracking Status
firefox27 --- unaffected
firefox28 - wontfix
firefox29 - ---
firefox30 - ---
firefox33 --- wontfix
firefox34 --- affected
firefox35 --- affected
firefox36 --- affected
firefox37 --- affected

People

(Reporter: petruta.rasa, Unassigned)

References

Details

(Keywords: regression)

Attachments

(1 file)

Reproduced on:
latest beta 20140218122424: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0
latest Aurora 20140220004001: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0
latest Nightly 20140219030203: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:30.0) Gecko/20100101 Firefox/30.0

Steps to reproduce:
1. Open Firefox
2. Open the following mp3, opus and ogg files:
http://www.texasbagpiper.com/soundclips/11%20-%20Track%2011.mp3
http://people.xiph.org/~giles/2012/opus/detodos.opus
http://upload.wikimedia.org/wikipedia/en/4/45/ACDC_-_Back_In_Black-sample.ogg

Expected result:
Only the control bar is shown, in the middle of the page.

Actual result:
The control bars position is moved up one position.
It seems that the controls interface is used by audio & video. This samples are only audio so the video's container is hidden (visual artifact).
On Aurora and Nightly builds the video container is also visible before the file is loaded.

Notes: 
1. The issue also reproduces on Ubuntu 13.10 64-bit and Mac OSX 10.7
2. The issue is not reproducing on Firefox 27.0.1 where the video container remains on the screen also for audio files (see bug 870779). Will investigate the regression range tomorrow, if needed.
Regression range:
Last good revision: 70de5e24d79b (2013-11-07)
First bad revision: f003c386c77a (2013-11-08)
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=70de5e24d79b&tochange=f003c386c77a

Seems to be regressed by bug 704326.
Blocks: 704326
Component: Video/Audio → Video/Audio Controls
Keywords: regression
Product: Core → Toolkit
Jared, can you please look into this?
Flags: needinfo?(jaws)
Version: Trunk → 28 Branch
With the current Australis work I won't have time to look in to this for 28 or 29. I *might* get to look at this on 30 when 30 is in late-Aurora.
Flags: needinfo?(jaws)
Can you include a screenshot of the problem?
Attached image audio file.png
This is how the player looks like for about 1 second when the file starts playing. Then, the controls bar is moved to the blank line (resized).
Whiteboard: p=0
Jared, do you think you could help here? Thanks
Flags: needinfo?(jaws)
The audio and video pages use the same code for showing their media, and this code assumes that the media is a video first. We show a loading throbber while the file is loading, and once we determine that the media is audio then we hide the loading throbber and only show the control bar. To fix this we would need to switch the code around to assume that media files are audio-only first, and then change size when we determine that there is video present.

Without digging too deep in to the code, I think this is a risky change to make late in the cycle and I've been too busy with Australis work as it is.

Paul Adenot may be able to help here.
Flags: needinfo?(jaws)
I don't think we should track this - it's a minor side effect of bug 704326 that we should improve, but we don't need to before shipping bug 704326.
I don't really have time, sorry.
Flags: needinfo?(paul)
No longer blocks: fxdesktopbacklog
Flags: firefox-backlog+
Whiteboard: p=0 → p=2
Points: --- → 2
Flags: qe-verify?
Whiteboard: p=2
Issue still reproducible with STR from comment 0 and 34 beta 10 (Build ID: 20141117202603) on Windows 7 64-bit, Windows 8 32-bit, Mac OS X 10.9.5 and Ubuntu 12.04 32-bit but only one scenario from Actual results:

(In reply to Petruta Rasa [QA] [:petruta] from comment #0)
> Actual result:
> On Aurora and Nightly builds the video container is also visible before the
> file is loaded.
You need to log in before you can comment on or make changes to this bug.