974968 - Extension name not listed in Extensions tab of report/index

Status: RESOLVED FIXED

(Socorro :: Webapp, task, P2)

Description

[guigs [:guigs] PST (please needinfo me!)]

Attachment: 2014-02-20_08-28-35_Extensiontab.png

When a crash report is submitted, the add on names are not added to the report. For troubleshooting purposes, adding these names will save a step of looking up the signatures or version number.

Comment 1

[Robert Helmer [:rhelmer]]

It looks like we only get the ID submitted with the crash, so we'd need to look this up. I believe that there used to be a lookup against addons.m.o, but that was not working for a long time and removed a while back.

I know that correlations uses a static list (http://hg.mozilla.org/users/dbaron_mozilla.com/crash-data-tools/file/0a9b16dd44bb/amo-ids.txt) but I don't believe that it's been kept up-to-date.

Comment 2

[Robert Kaiser]

We should bring back that lookup, it helps a lot in diagnosing what is installed for a user - and we even have the column for it in the UI already. :)
Also, I think a (near-)live lookup from AMO can make us revive the "Current?" column as well, which would also be awesome, esp. for people like Rachel and Patrick who are trying to help users with their issues.

And I think for the new in-Socorro correlations we will want to have this done properly in Socorro as well. :)

Comment 3

[Robert Helmer [:rhelmer]]

(In reply to Robert Kaiser (:[e-mail]) from comment #2)
> We should bring back that lookup, it helps a lot in diagnosing what is
> installed for a user - and we even have the column for it in the UI already.
> :)
> Also, I think a (near-)live lookup from AMO can make us revive the
> "Current?" column as well, which would also be awesome, esp. for people like
> Rachel and Patrick who are trying to help users with their issues.
> 
> And I think for the new in-Socorro correlations we will want to have this
> done properly in Socorro as well. :)

OK, let's pull it into the DB (like we do for bugs for instance), then we can easily join against it. The old way did it from the web app and never worked very well.

Comment 4

[Robert Kaiser]

(In reply to Robert Helmer [:rhelmer] from comment #3)
> OK, let's pull it into the DB (like we do for bugs for instance), then we
> can easily join against it. The old way did it from the web app and never
> worked very well.

Sounds reasonable, if we poll AMO for the list every day or so, we should always have reasonably up-to-date data we can report in the UI.

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

If the crash report has a TelemetryEnvironment, then the activeAddons object maps addon id -> object which has a name key. I think instead of pulling/pushing information to AMO, I'd rather use that if it's available and call it a day.

Making this a P2.

Comment 7

[Will Kahn-Greene [:willkg] ET needinfo? me]

Grabbing this to work on now.

Comment 8

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 5749: bug 974968, 1629943: improve Extensions tab

Comment 9

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #5749: "bug 974968, 1629943: improve Extensions tab" in 8686fcf.

Comment 10

[Will Kahn-Greene [:willkg] ET needinfo? me]

This was deployed to prod in bug #1706647. Marking as FIXED.