974984 - Add debug traces using the shared Gaia debug facility to the WAP Push app

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Wappush, defect)

Description

[Gabriele Svelto [:gsvelto]]

Currently we don't print any debug information at all in the WAP Push app and this is somewhat problematic when bugs are filed as the logcat doesn't usually contain useful information.

We should print out some debugging info using the shared Gaia debug DUMP function (shared/js/dump.js); this would include at least:

- the full contents of the received message

- its lifecycle (if it's been stored in the DB, if it updated an existing one, etc...)

- the operations involving notifications (opened, tapped, updated, etc...)

- message-type specific operations (such as clicking on links or accepting content provisioning messages)

Comment 1

[Gabriele Svelto [:gsvelto]]

Attachment: [PATCH] Added basic debug logging

This is a super-simple patch that adds a minimum of logging to the application. In spite of adding only some very basic logging it would have helped a lot with some of the recent bugs... We can add more complex logging as we refactor the app.

Comment 2

[Gabriele Svelto [:gsvelto]]

Attachment: [PULL REQUEST] Added basic debug logging

Thanks for the quick review, this is the PR, I'll be waiting for the try run to turn green before merging:

https://tbpl.mozilla.org/?rev=f78ddfe9f682909906c3a9c5088e088cb50fa80d&tree=Gaia-Try

Comment 3

[Gabriele Svelto [:gsvelto]]

Comment on attachment 8474534 [details] [review]
[PULL REQUEST] Added basic debug logging

>https://github.com/mozilla-b2g/gaia/pull/22993

Comment 4

[Gabriele Svelto [:gsvelto]]

Merged to gaia/master c5983047b4420d361b03de6c0f9f3e9c3e4bc6cc

https://github.com/mozilla-b2g/gaia/commit/c5983047b4420d361b03de6c0f9f3e9c3e4bc6cc