974986 - Specify stack address in SamplerStackFramePrintfRAII::SamplerStackFramePrintfRAII

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

This line at [1] runs when using SamplerStackFramePrintfRAII when the profiler is inactive or in privacy mode,

> mHandle = mozilla_sampler_call_enter(aDefault, nullptr, false, line);

I think it's a bug that it passes nullptr as the stack address.

[1] http://mxr.mozilla.org/mozilla-central/source/tools/profiler/GeckoProfilerImpl.h?rev=82cd92e10736#335

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Always specify stack address in SamplerStackFramePrintfRAII (v1)

One line fix

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/560957199199

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/560957199199