97502 - LDAP server in prefs list of servers changes to "null".

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect, P3)

Description

[Steve Meredith (gone)]

From the "Addressing" prefs windows, press the "Edit Directories..." button.
Press "Add" and add a new server to the list. The values here don't matter.
Now press "Edit" for one of the existing servers in the list. 
Press "Cancel" on the "Directory Server Properties" dialog which comes up.
The selected server in the list is changed to "null." It's properties are now gone.

Comment 1

[yulian chang]

Reassign to Srilatha

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

*** Bug 98438 has been marked as a duplicate of this bug. ***

Comment 3

[Marek Z. Jeziorek]

nsbranch+ per pdt triage
appears to be data loss

Comment 4

[Srilatha Moturi]

OK I have a fix for this.
When a new directory is added gUpdate is set to true and we are not resetting it 
to false. In editDirectory we are checking in gUpdate is true...
gUpdate should be true only if the user has clicked ok on the Directory 
Server Properties dialog. The fix is to set gUpdate to false before we open 
Directory Server Properties dialog.

Comment 5

[Srilatha Moturi]

Attachment: patch v1

Comment 6

[Srilatha Moturi]

ccing [e-mail] for review.

Comment 7

[Srilatha Moturi]

From the "Addressing" prefs windows, press the "Edit Directories..." button.
select a server
then click on "Edit" and then click "Ok" in "Directory Server Properties" 
Dialog.
Then click on "New" and then click "Cancel" in "Directory Server Properties" 
Dialog.
a new server is added to the list of server with the same name as the one you 
just edited.

Have a fix which fixes this too.
will post a new patch right away.

Comment 8

[Srilatha Moturi]

Attachment: patch v2

Comment 9

[Srilatha Moturi]

Attachment: path v3

Comment 10

[Srilatha Moturi]

After discussing with Mitesh, we decided setting gUpdate to false in OnCancel is 
a better solution.  Thanks Mitesh
Mitesh please review.

Comment 11

[Mitesh Shah]

Comment on attachment 50345 [details] [diff] [review]
path v3

sounds good

Comment 12

[(not reading, please use [e-mail] instead)]

Comment on attachment 50345 [details] [diff] [review]
path v3

sr=sspitzer

Comment 13

[Jaime Rodriguez, Jr.]

check it in - PDT+

Comment 14

[Srilatha Moturi]

Fix checked into both trunk and branch.

Comment 15

[yulian chang]

Verified with 20010925 0.9.4 builda on NT, Linux and MacOS 9.2.