Closed Bug 975029 Opened 7 years ago Closed 7 years ago

Make comm-central work with infallible-by-default PL_DHashTableInit

Categories

(MailNews Core :: Backend, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 30.0

People

(Reporter: mccr8, Assigned: mccr8)

References

Details

Attachments

(1 file)

PL_DHashTableInit is called in three places in mailnews/.  These will have to be updated when bug 962608 lands on mozilla-central.  The easiest fix is to just pass in fallible_t() as an additional argument, which will retain the current behavior.

http://mxr.mozilla.org/comm-central/source/mailnews/db/msgdb/src/nsMsgDatabase.cpp#617
http://mxr.mozilla.org/comm-central/source/mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp#187
http://mxr.mozilla.org/comm-central/source/mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp#210
Assignee: nobody → continuation
Attached patch update itSplinter Review
I took the simplest approach here and just made all of these callsites fallible, preserving the current behavior.
Attachment #8380062 - Flags: review?(mbanner)
Also, would I just land this on comm-central at the same time as I land bug 962608 on mozilla-central?
Comment on attachment 8380062 [details] [diff] [review]
update it

Review of attachment 8380062 [details] [diff] [review]:
-----------------------------------------------------------------

Neil, can you take a look at these please?
Attachment #8380062 - Flags: review?(mbanner) → review?(neil)
Comment on attachment 8380062 [details] [diff] [review]
update it

Seems reasonable, given that PL_NewDHashTable is still fallible.
Attachment #8380062 - Flags: review?(neil) → review+
Whiteboard: [needs to land on c-c after bug 962608 is merged to m-c]
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 30.0
You need to log in before you can comment on or make changes to this bug.