975029 - Make comm-central work with infallible-by-default PL_DHashTableInit

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Andrew McCreight [:mccr8]]

PL_DHashTableInit is called in three places in mailnews/.  These will have to be updated when bug 962608 lands on mozilla-central.  The easiest fix is to just pass in fallible_t() as an additional argument, which will retain the current behavior.

http://mxr.mozilla.org/comm-central/source/mailnews/db/msgdb/src/nsMsgDatabase.cpp#617
http://mxr.mozilla.org/comm-central/source/mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp#187
http://mxr.mozilla.org/comm-central/source/mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp#210

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: update it

I took the simplest approach here and just made all of these callsites fallible, preserving the current behavior.

Comment 2

[Andrew McCreight [:mccr8]]

Also, would I just land this on comm-central at the same time as I land bug 962608 on mozilla-central?

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 8380062 [details] [diff] [review]
update it

Review of attachment 8380062 [details] [diff] [review]:
-----------------------------------------------------------------

Neil, can you take a look at these please?

Comment 4

[[e-mail]]

Comment on attachment 8380062 [details] [diff] [review]
update it

Seems reasonable, given that PL_NewDHashTable is still fallible.

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

 https://hg.mozilla.org/comm-central/rev/febc91ed7a0b