975063 - Apps are not being filtered by buchets on Android

Status: RESOLVED FIXED

(Marketplace Graveyard :: API, defect, P1)

Description

[David Bialer [:dbialer]]

all the featured apps and popular apps are not supported on Android.  Shouldn't these only show compatible apps for Android?

Comment 1

[Christopher Van Wiemeersch [:cvan]]

See bug 919780. Maybe consider just doing buchets for non-desktop like we do everywhere else.

Comment 2

[Wil Clouser [:clouserw]]

(In reply to Christopher Van Wiemeersch [:cvan] from comment #1)
> See bug 919780. Maybe consider just doing buchets for non-desktop like we do
> everywhere else.

That's the plan we talked about at the work week.  (And desktop can opt in/out based on the toggle)

Comment 3

[Rob Hudson [:robhudson]]

I took a look at the underlying ES queries.

Popularity looks good from what I can tell. It's properly filtering by device (but not buchets). Testing on my android looks correct too -- I get different apps starting off the list than I do on desktop.

Feature apps are a different story. I see no indication of any device or buchet filtering. I looked at the queries for desktop, android, and fxos and they are the same.

From what I understand at this point, this bug is to add device and buchet filtering to the featured app queries when device != DESKTOP.

Comment 4

[Wil Clouser [:clouserw]]

That sounds right, with the knowledge that desktop is going to have a toggle so it *might* filter or might not

Comment 5

[Rob Hudson [:robhudson]]

https://github.com/mozilla/fireplace/commit/a378a068

This commit fixes a bug in fireplace that caused it to not send the buchet profile as part of the API call. The API already handles filtering by buchets if provided.

I've verified that the ES queries are now filtering by buchets and that apps are filtered out if they aren't supported. E.g. on -dev the pomodoro app is listed in the collection but is filtered out on android b/c it doesn't support the mozActivities buchet.

This bug is almost fixed except for filtering by device type. I still see some apps showing up on my andriod device that I can't install b/c apps are listed as FirefoxOS-only yet the buchets match. Fireplace also sends the device to the API so this is just a matter of updating the API to take it into account as part of the API.

Comment 6

[Rob Hudson [:robhudson]]

https://github.com/mozilla/zamboni/commit/983a881 

This commit adds the device filtering to the API as mentioned in comment 5.

To verify:
* Add android apps and fxos apps to a collection and featured apps.
* Verify that you do not see the fxos-only apps on android, and you don't see the android-only apps on fxos.
* Do a similar verification with various buchets.

Comment 7

[Rob Hudson [:robhudson]]

Reopened b/c device filtering doesn't work. Fireplace passes ?dev=android&device=mobile but the lookup we use in the API has either 'android-mobile' or 'android-tablet'.

Assuming we pass device=tablet for tablets we still can't just do:

  '%s-%s' % (request.GET['dev'], request.GET['device'])`

because we also pass ?dev=firefoxos&device=firefoxos iirc. Likewise for desktop.

I'll attempt to fix this tomorrow.

Comment 8

[Rob Hudson [:robhudson]]

https://github.com/mozilla/zamboni/commit/a898056 

This commit fixes the problem in comment 7.

See comment 6 for verification steps.

Comment 9

[krupa raj[:krupa]]

https://marketplace-dev.allizom.org/developers/app/test-app-khvk/payments/ is a featured app which is supported on Android mobile.

featured collections is @ https://marketplace-dev.allizom.org/curation/collection/featuredtwo

however on my google nexus this app doesn't show up.

It doesn't show up on desktop either but that i assume by design.

Comment 10

[Rob Hudson [:robhudson]]

That app is in the search index but doesn't have the collection set, which is why it's not showing up. Somewhere the re-index to add this app to the collection failed to work -- I see it in the db.

I reindexed the app and it should show up in the collection now.

I'd argue that's a separate bug from this and one we should look into if we can get steps to reproduce it.

Comment 11

[Victor Carciu]

I can't test the scenario from comment 6 because of https://bugzilla.mozilla.org/show_bug.cgi?id=928353.

Anyway , we tried some scenarios with different buchets and filtering appears to be ok, but I will wait until the bug from above will be fixed for a complete verification.