975091 - Extra padding on some list item titles

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect, P1)

Description

[:Margaret Leibovic]

Attachment: screenshot (see last item)

See item at the bottom of the screenshot. Lucas, do you know what could be causing this?

Comment 1

[Lucas Rocha (:lucasr)]

Some bad interaction between view recycling and linear layouts with layout_weight I guess. Is it easy to reproduce?

Comment 2

[Lucas Rocha (:lucasr)]

Attachment: Use wrap_content height params in PanelArticleItem (r=margaret)

Comment 3

[Lucas Rocha (:lucasr)]

Comment on attachment 8394244 [details] [diff] [review]
Use wrap_content height params in PanelArticleItem (r=margaret)

Using fill_content with layout_weight was getting ListView all confused. Just wrap content and use center_vertical gravity in the title/description container.

Comment 4

[Lucas Rocha (:lucasr)]

https://hg.mozilla.org/integration/fx-team/rev/9b5ee3b24326

Comment 5

[Lucas Rocha (:lucasr)]

Promoting this bug as P1 as it's requirement for RSS panels.

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9b5ee3b24326

Comment 7

[:Margaret Leibovic]

Comment on attachment 8394244 [details] [diff] [review]
Use wrap_content height params in PanelArticleItem (r=margaret)

[Approval Request Comment]
Bug caused by (feature/regressing bug #): new hub APIs in fx30
User impact if declined: dynamic panels can have too much padding
Testing completed (on m-c, etc.): baked on m-c
Risk to taking this patch (and alternatives if risky): low-risk padding tweak
String or IDL/UUID changes made by this patch: none

Comment 8

[:Margaret Leibovic]

Comment on attachment 8394244 [details] [diff] [review]
Use wrap_content height params in PanelArticleItem (r=margaret)

Lukas and I discussed this on IRC - I missed uplifting this for the merge, which isn't a big deal, but I will need to land it on beta after the merge is finished.

Comment 9

[:Margaret Leibovic]

https://hg.mozilla.org/releases/mozilla-beta/rev/bd20a12260ea

Comment 10

[Cristina Madaras, QA [:CristinaM]]

I verified this with Wikipedia and Goal.com panels and looks good, is not reproducible. I used Nightly (2014-05-09) and Galaxy Nexus (Android 4.2.1).

Comment 11

[Teodora Vermesan (:TeoVermesan)]

Verified fixed on:
Build: Firefox for Android 30 Beta 4
Device: Alcatel One Touch (Android 4.1.2) 
Add-ons: wikipedia, pocket

Comment 12

[Teodora Vermesan (:TeoVermesan)]

Verified fixed on:
Build: Firefox for Android 31.0a2 (2014-05-16)
Device: Alcatel One Touch (Android 4.1.2) 
Add-on: pocket panel

Comment 13

[:Margaret Leibovic]

Setting P1 hub bugs to block hub v1 EPIC bug (targeting fx30 release).

Filter on epic-hub-bugs.