975152 - Eclipse complains about missing @drawable/crash_reporter icon

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Brian Nicholson (:bnicholson)]

After a fresh project creation:

No resource found that matches the given name (at 'icon' with value '@drawable/crash_reporter').	AndroidManifest.xml	/Fennec	line 1471	Android AAPT Problem

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: Include CrashReporter resources in Android Eclipse projects. r=bnicholson

Comment 2

[Nick Alexander :nalexander [he/him]]

Attachment: Part 0: Allow res=None in AndroidEclipseProjectData. r=bnicholson

Comment 3

[Nick Alexander :nalexander [he/him]]

Attachment: Part 1: Include CrashReporter resources in Android Eclipse projects. r=bnicholson

The set of resources of all the Android library projects are processed
at once.  That means that the bi-directional dependency between the main
project resources and the crash reporter resources causes no build time
problems.  Therefore, this patch moves all the main project resources
into a library project (FennecResources) and adds an optional additional
library project (FennecCrashReporterResources).

Comment 4

[Nick Alexander :nalexander [he/him]]

Attachment: Part 2: Make Fennec* projects sort nicely in Eclipse. r=bnicholson

This orders projects like:

Fennec
FennecResources
FennecResourcesBranding
...

which is in order of expected use.

Comment 5

[Brian Nicholson (:bnicholson)]

Comment on attachment 8380215 [details] [diff] [review]
Part 2: Make Fennec* projects sort nicely in Eclipse. r=bnicholson

Review of attachment 8380215 [details] [diff] [review]:
-----------------------------------------------------------------

Tested these and they worked fine. Eclipse-generated APK builds and installs with no errors.

Comment 6

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/fx-team/rev/d5ac8e460f2e
https://hg.mozilla.org/integration/fx-team/rev/2270c5490879
https://hg.mozilla.org/integration/fx-team/rev/97cedf504412

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d5ac8e460f2e
https://hg.mozilla.org/mozilla-central/rev/2270c5490879
https://hg.mozilla.org/mozilla-central/rev/97cedf504412