Closed
Bug 975157
Opened 10 years ago
Closed 10 years ago
Day/week view: the off-time zone get shifted one hour later in the timebar when changing the "Day ends at" setting
Categories
(Calendar :: Calendar Frontend, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
3.0
People
(Reporter: bv1578, Assigned: bv1578)
Details
Attachments
(1 file)
918 bytes,
patch
|
Taraman
:
review+
Fallen
:
approval-calendar-aurora+
Fallen
:
approval-calendar-beta+
Fallen
:
approval-calendar-esr-
|
Details | Diff | Splinter Review |
Steps to reproduce: 1. switch to week view or day view; 2. change the setting "Day ends at" in the menu Tools > Options > Calendar > Views to a different hour; Actual result: the off-time zone in the view is correctly set to the new hour, but in the time-bar it starts to the new hour + 1. This happens because in the method "setDayStartEndHours" the "off-time" attribute is set to the hour following the "Day end at" hour.
Attachment #8379298 -
Flags: review?(Mozilla)
Comment 1•10 years ago
|
||
Comment on attachment 8379298 [details] [diff] [review] patch - v1 Review of attachment 8379298 [details] [diff] [review]: ----------------------------------------------------------------- Confirmed to work. since it's a very small patch also a candidate for backporting. r=markus
Attachment #8379298 -
Flags: review?(Mozilla) → review+
Pushed to comm-central: http://hg.mozilla.org/comm-central/rev/7d965b09bf3a
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.2
Version: Lightning 3.2 → Lightning 2.6.4
Attachment #8379298 -
Flags: approval-calendar-release?(philipp)
Attachment #8379298 -
Flags: approval-calendar-beta?(philipp)
Attachment #8379298 -
Flags: approval-calendar-aurora?(philipp)
Comment 3•10 years ago
|
||
Comment on attachment 8379298 [details] [diff] [review] patch - v1 I think we should avoid putting too much into the 2.6.x releases, I've painfully found out how even a small CSS change can horribly break everything. I'm sure this is a low risk fix, but unless there is major user impact I think we shouldn't push our luck.
Attachment #8379298 -
Flags: approval-calendar-release?(philipp)
Attachment #8379298 -
Flags: approval-calendar-release-
Attachment #8379298 -
Flags: approval-calendar-beta?(philipp)
Attachment #8379298 -
Flags: approval-calendar-beta+
Attachment #8379298 -
Flags: approval-calendar-aurora?(philipp)
Attachment #8379298 -
Flags: approval-calendar-aurora+
Pushed to comm-aurora -> http://hg.mozilla.org/releases/comm-aurora/rev/688071119edd comm-beta -> http://hg.mozilla.org/releases/comm-beta/rev/14e26bcb0f42
Target Milestone: 3.2 → 3.0
You need to log in
before you can comment on or make changes to this bug.
Description
•