975157 - Day/week view: the off-time zone get shifted one hour later in the timebar when changing the "Day ends at" setting

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Decathlon]

Attachment: patch - v1

Steps to reproduce:

1. switch to week view or day view;
2. change the setting "Day ends at" in the menu Tools > Options > Calendar > Views to a different hour;

Actual result:
the off-time zone in the view is correctly set to the new hour, but in the time-bar it starts to the new hour + 1.

This happens because in the method "setDayStartEndHours" the "off-time" attribute is set to the hour following the "Day end at" hour.

Comment 1

[Markus Adrario [:Taraman]]

Comment on attachment 8379298 [details] [diff] [review]
patch - v1

Review of attachment 8379298 [details] [diff] [review]:
-----------------------------------------------------------------

Confirmed to work.
since it's a very small patch also a candidate for backporting.

r=markus

Comment 2

[Decathlon]

Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/7d965b09bf3a

Comment 3

[Philipp Kewisch [:Fallen][☁️📆]]

Comment on attachment 8379298 [details] [diff] [review]
patch - v1

I think we should avoid putting too much into the 2.6.x releases, I've painfully found out how even a small CSS change can horribly break everything. I'm sure this is a low risk fix, but unless there is major user impact I think we shouldn't push our luck.

Comment 4

[Decathlon]

Pushed to
comm-aurora -> http://hg.mozilla.org/releases/comm-aurora/rev/688071119edd
comm-beta   -> http://hg.mozilla.org/releases/comm-beta/rev/14e26bcb0f42