975167 - Traceback in autocompletion while debugging

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[Jeff Griffiths (:canuckistani) (:⚡︎)]

STR:

1. go to any bugzilla bug, for example this one
2. open the debugger, go to comments.js and put a breakpoint on line 53 ( in toggle_all_comments() )
3. open the split console and type in this:

var x = [[1, 2, 3, 4], [1, 2, 3, 4], [1, 2, 3, 4]]

4. try to get completion on one of the nested arrays, eg

x[0].

I get these tracebacks:

error occurred while processing 'autocomplete: TypeError: aName is not an identifier
Stack: DebuggerEnvironmentSupport.getProperty@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/toolkit/webconsole/utils.js:1046
getExactMatch_impl@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/toolkit/webconsole/utils.js:978
getVariableInEnvironment@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/toolkit/webconsole/utils.js:884
JSPropertyProvider@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/toolkit/webconsole/utils.js:827
WCA_onAutocomplete@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/main.js -> resource://gre/modules/devtools/server/actors/webconsole.js:732
DSC_onPacket@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/main.js:1023
LDT_send/<@resource://gre/modules/devtools/dbg-client.jsm -> resource://gre/modules/devtools/server/transport.js:258
makeInfallible/<@resource://gre/modules/devtools/DevToolsUtils.jsm -> resource://gre/modules/devtools/DevToolsUtils.js:80
Line: 1046, column: 0


onPacket threw an exception: Error: Server did not specify an actor, dropping packet: {"error":"unknownError","message":"error occurred while processing 'autocomplete: TypeError: aName is not an identifier\nStack: DebuggerEnvironmentSupport.getProperty@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/toolkit/webconsole/utils.js:1046\ngetExactMatch_impl@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/toolkit/webconsole/utils.js:978\ngetVariableInEnvironment@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/toolkit/webconsole/utils.js:884\nJSPropertyProvider@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/toolkit/webconsole/utils.js:827\nWCA_onAutocomplete@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/main.js -> resource://gre/modules/devtools/server/actors/webconsole.js:732\nDSC_onPacket@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/main.js:1024\nLDT_send/<@resource://gre/modules/devtools/dbg-client.jsm -> resource://gre/modules/devtools/server/transport.js:258\nmakeInfallible/<@resource://gre/modules/devtools/DevToolsUtils.jsm -> resource://gre/modules/devtools/DevToolsUtils.js:80\nLine: 1046, column: 0"}
Stack: DebuggerClient.prototype.onPacket/<@resource://gre/modules/devtools/dbg-client.jsm:655
resolve@resource://gre/modules/commonjs/sdk/core/promise.js:118
then@resource://gre/modules/commonjs/sdk/core/promise.js:43
then@resource://gre/modules/commonjs/sdk/core/promise.js:153
DebuggerClient.prototype.onPacket@resource://gre/modules/devtools/dbg-client.jsm:705
LDT_send/<@resource://gre/modules/devtools/dbg-client.jsm -> resource://gre/modules/devtools/server/transport.js:258
makeInfallible/<@resource://gre/modules/devtools/DevToolsUtils.jsm -> resource://gre/modules/devtools/DevToolsUtils.js:80
Line: 655, column: 0

Comment 1

[Mihai Sucan [:msucan]]

Attachment: bug975167-1.diff

The problem is we try getVariable() with aName set to 'foo[whatever]'. We do not parse the string, we just split on '.', thus aName is an invalid identifier. We should, in the future, support at least array indexes.

Try push: https://tbpl.mozilla.org/?tree=Try&rev=ef7246501a15

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 8379922 [details] [diff] [review]
bug975167-1.diff

Review of attachment 8379922 [details] [diff] [review]:
-----------------------------------------------------------------

OK, let's just make sure a followup is filed for autocompleting array indexes.

Comment 3

[Mihai Sucan [:msucan]]

(In reply to Panos Astithas [:past] from comment #2)
> Comment on attachment 8379922 [details] [diff] [review]
> bug975167-1.diff
> 
> Review of attachment 8379922 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> OK, let's just make sure a followup is filed for autocompleting array
> indexes.

Thanks! We already have bug 943586 for that issue.

Comment 5

[Mihai Sucan [:msucan]]

Landed: https://hg.mozilla.org/integration/fx-team/rev/4aecbfc2da19

Comment 6

[Mihai Sucan [:msucan]]

Comment on attachment 8379922 [details] [diff] [review]
bug975167-1.diff

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 842682.
User impact if declined: the console stops working if you try to use array indexes or if you try to access properties using the obj['propName'] notation, while debugging a script.
Testing completed (on m-c, etc.): landed in fx-team, a test is included, and a green try push.
Risk to taking this patch (and alternatives if risky): minimal, it's just a try-catch around a debugger API call.
String or IDL/UUID changes made by this patch: none.

Comment 7

[Sylvestre Ledru [:Sylvestre]]

I will approve it once it reached m-c. thanks.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4aecbfc2da19

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/5d487f51d04b