975198 - Globe icon appears when image doesn't load in grid view

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect, P1)

Description

[:Margaret Leibovic]

Attachment: screenshot

See screenshot. I assume we have something in place to fall back to our default favicon, which we shouldn't do here.

Question is, what should we do? Show a solid color? We'll need to consider the case where the user doesn't have a network connection and can have difficulty loading remote images, since add-ons don't necessarily store local images.

Comment 1

[Ian Barlow (:ibarlow)]

I think it might be best to leave it blank. We start with that pale blue and then fade the image in when it loads. So the placeholder should probably just be that blue colour.

Comment 2

[Lucas Rocha (:lucasr)]

Attachment: Don't use default favicon as placeholder in PanelItemView (r=margaret)

Comment 3

[Lucas Rocha (:lucasr)]

Comment on attachment 8380556 [details] [diff] [review]
Don't use default favicon as placeholder in PanelItemView (r=margaret)

Leftover from the PanelItemView work in bug 966022. Ian, what's the placeholder for the article view (the one used for RSS)?

Comment 4

[Ian Barlow (:ibarlow)]

Hm good question. Don't show the row?

Comment 5

[Lucas Rocha (:lucasr)]

https://hg.mozilla.org/integration/fx-team/rev/59b615846cf2

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/59b615846cf2

Comment 7

[:Margaret Leibovic]

Setting P1 hub bugs to block hub v1 EPIC bug (targeting fx30 release).

Filter on epic-hub-bugs.