975230 - [Sora][FM][settings]FM would not pause while actived sound settings

Status: RESOLVED DUPLICATE of bug 958470

(Firefox OS Graveyard :: Gaia::Settings, defect, P1)

Description

[sync-1]

Firefox OS v1.3
 Mozilla build ID: 20140208004002
 
 DEFECT DESCRIPTION:
 FM would not pause while actived sound settings
 
  REPRODUCING PROCEDURES:
 1.Insert headset;
 2.Launch FM and select one channel to play;
 3.Listening FM in background;
 4.Settings->sound,listen ringer or alert ringtone.Ringtone and FM can play simultaneously;->KO
 
  EXPECTED BEHAVIOUR:
 When activated sound settings,FM should pause;
 
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 
  TOOLS AND PLATFORMS USED:
 
  USER IMPACT:
 
  REPRODUCING RATE:5/5
 
  For FT PR, Please list reference mobile's behavior:

Comment 1

[Jason Smith [:jsmith]]

Does this reproduce on 1.1 Buri?

Comment 2

[Ray REN]

(In reply to Jason Smith [:jsmith] from comment #1)
> Does this reproduce on 1.1 Buri?

Yes. On 1.1 Buri when activated sound settings,FM have mute.

Comment 3

[Jason Smith [:jsmith]]

(In reply to Ray REN from comment #2)
> (In reply to Jason Smith [:jsmith] from comment #1)
> > Does this reproduce on 1.1 Buri?
> 
> Yes. On 1.1 Buri when activated sound settings,FM have mute.

Wait - do you mean that this works fine on 1.1 then?

Comment 4

[Ray REN]

(In reply to Jason Smith [:jsmith] from comment #3)
> (In reply to Ray REN from comment #2)
> > (In reply to Jason Smith [:jsmith] from comment #1)
> > > Does this reproduce on 1.1 Buri?
> > 
> > Yes. On 1.1 Buri when activated sound settings,FM have mute.
> 
> Wait - do you mean that this works fine on 1.1 then?

Yes, it works fine on 1.1

Comment 5

[Dominic Kuo [:dkuo]]

Bug 958470 should also fix this.

Comment 6

[Jason Smith [:jsmith]]

(In reply to Dominic Kuo [:dkuo] from comment #5)
> Bug 958470 should also fix this.

I think this bug should be fixed independently of that bug - keep that bug's focus on the Ringtones app specifically.

Comment 8

[Jason Smith [:jsmith]]

The fact that this is happening in multiple places makes me think that we're fundamentally not doing audio channels correctly.

Comment 9

[Dominic Kuo [:dkuo]]

(In reply to Jason Smith [:jsmith] from comment #6)
> (In reply to Dominic Kuo [:dkuo] from comment #5)
> > Bug 958470 should also fix this.
> 
> I think this bug should be fixed independently of that bug - keep that bug's
> focus on the Ringtones app specifically.

Before 1.2, that's 1.1, the capability of setting the ringtone was a sub-module of the settings app, and because the audio channel type was correctly set at that time, 1.1 didn't has this issue.

In 1.2, djf had implemented a new app called "ringtones" in bug 905856 to support setting forward lock content as the ringtone, from 1.2 we started to pick the ringtone from the ringtones app. The ringtone's logic in settings app was removed and added to the new ringtones app, the audio channel type was probably the missing part we forgot to move then caused this issue, so that's why I filed bug 958470 and tried to fix it.

Comment 10

[Jason Smith [:jsmith]]

QA Wanted to confirm this in the latest 1.3 build.

Comment 11

[Montoya Clemmons (MClemmons)]

In response to Comment 10  Jason Smith [:jsmith] 2014-02-24 20:46:40 PST 
QA Wanted to confirm this in the latest 1.3 build.

Confirmed this issue occurs on the latest 1.3 build with below Environmental Variables. I am able to play and hear FM Radio, go to Settings and select a ringtone or alert, and hear both FM Radio and the ringtone/alert at the same time. 

Environmental Variables:
Device: Buri 1.3 MOZ
BuildID: 20140225004004
Gaia: 6e883bde818d4d53aef7b5b075b4b34267918360
Gecko: e597280f9300
Version: 28.0
Base Image: v1.2-device.cfg

Comment 12

[Montoya Clemmons (MClemmons)]

The issue started reproducing on the 9/20/2013 1.3 build. On this build I am able to play and hear FM Radio, go to Settings and select a ringtone or alert, and hear both FM Radio and the ringtone/alert at the same time. 

The following regression window was found:

Last Working
Environmental Variables:
Device: Buri 1.3 MOZ
BuildID: 20130919040201
Gaia: 0dedb5b3789afc638a0c7c67652937fcb30e77d2
Gecko: 803189f35921
Version: 27.0a1
Base Image: v1.2-device.cfg

First Broken
Environmental Variables:
Device: Buri 1.3 MOZ
BuildID: 20130920040201
Gaia: 78a3e2509b979bd226f01f557bdf229fd3faa42e
Gecko: 59beb1868522
Version: 27.0a1
Base Image: v1.2-device.cfg

Comment 13

[Jason Smith [:jsmith]]

This is missing a last gaia working/first gecko busted & vice versa analysis.

Comment 14

[Montoya Clemmons (MClemmons)]

(In reply to Jason Smith [:jsmith] from comment #13)
> This is missing a last gaia working/first gecko busted & vice versa analysis.

Regression Window

Last Working
Environmental Variables:
Device: Buri 1.3 MOZ
BuildID: 20130919040201
Gaia: 0dedb5b3789afc638a0c7c67652937fcb30e77d2
Gecko: 803189f35921
Version: 27.0a1
Base Image: v1.2-device.cfg

First Broken
Environmental Variables:
Device: Buri 1.3 MOZ
BuildID: 20130920040201
Gaia: 78a3e2509b979bd226f01f557bdf229fd3faa42e
Gecko: 59beb1868522
Version: 27.0a1
Base Image: v1.2-device.cfg

First Broken Gaia/Last Working Gecko - issue reproduces
Gaia: 78a3e2509b979bd226f01f557bdf229fd3faa42e
Gecko: 803189f35921

Last Working Gaia/First Broken Gecko: - issue does not reproduce
Gaia: 0dedb5b3789afc638a0c7c67652937fcb30e77d2
Gecko: 59beb1868522

push log:
https://github.com/mozilla-b2g/gaia/compare/0dedb5b3789afc638a0c7c67652937fcb30e77d2
...78a3e2509b979bd226f01f557bdf229fd3faa42e

Comment 15

[Jason Smith [:jsmith]]

https://github.com/mozilla-b2g/gaia/compare/0dedb5b3789afc638a0c7c67652937fcb30e77d2...78a3e2509b979bd226f01f557bdf229fd3faa42e

Comment 16

[Jason Smith [:jsmith]]

The only patch that seems plausible in the regression range is bug 905856, given that I see modifications in that patch in sound.js file.

David - Any ideas?

Comment 17

[David Flanagan [:djf]]

Jason,

My idea is to listen to Dominic (comment #9), since he is the only one on this bug who knows what they are talking about.  Look at step 4 of the STR: this bug is about ringtones.  Dominic is fixing a bug about ringtones.

Dominic and Jim have a plan to fix this that got pushed off to 1.5.  A 1.3+ bug is just what we need to get it fixed sooner.

Changing the component back to AudioChannel, and setting needinfo for Dominic and Jim to find out if either of them can get on this ASAP.

Comment 18

[Jim Porter (:squib)]

David: We'll probably just need to do the same sort of thing for this as you did for music and setringtone (just kill me now).

Maybe we can get around this by making the ringtone app play on a higher-priority channel, but I have a vague recollection that that doesn't actually save us. Dominic probably knows more about this.

Either way, I can implement this once I know what I'm implementing. :)

Comment 19

[Jim Porter (:squib)]

Clearly I read these bugs in the wrong order. Bug 958470 has much more useful info, and we should probably just dupe these.

(Aside: maybe duping an issue before we're sure that one actually fixes the other is frowned upon because it makes tracking harder, but this is a perfect example of why we should do it anyway: it's really hard to track which bug is the one we should be discussing technical details in.)

Comment 20

[Jason Smith [:jsmith]]

This is not a gecko bug - comment 14 already provides hard evidence that this is triggered in Gaia, not Gecko. There's also no evidence in the push log of anything in the System app triggering this. Back over to the Settings.

Comment 21

[Jason Smith [:jsmith]]

(In reply to Jim Porter (:squib) from comment #19)
> Clearly I read these bugs in the wrong order. Bug 958470 has much more
> useful info, and we should probably just dupe these.

We really should keep this bug open separate from bug 958470 - bug 958470 is focusing on a Web Audio solution to the problem, which is too risky to take into 1.3. We need a safe fix here for 1.3.

Comment 22

[Jason Smith [:jsmith]]

I'll dupe this per discussion with Jim & + the dupe.