975312 - [mozrunner] Runner.check_for_crashes() should support save_path and quiet parameters

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Right now the check_for_crashes() method of the Runner class does not support the save_path parameter of mozcrash. We have to get this added so that Mozmill can use it on bug 619204.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Test frameworks might not always want to let the information printed to stdout, but handle it on their own. So also forwarding the quiet parameter sounds important to me.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Patch v1

I also pushed this to try:
https://tbpl.mozilla.org/?tree=Try&rev=00aa990af6bf

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Patch v1.1

Included the mozrunner version bump too.

Comment 4

[Andrew Halberstadt [:ahal]]

Comment on attachment 8379660 [details] [diff] [review]
Patch v1.1

Review of attachment 8379660 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6ce5b0f27bd5

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6ce5b0f27bd5

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Damn. Somehow I pushed the wrong patch to inbound which didn't include the version bump. :/ I will most likely do it later or wait until I'm back.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Pushed version bump to 5.35:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f42032325f18

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to Henrik Skupin (:whimboo) [away 02/24 - 02/28] from comment #8)
> Pushed version bump to 5.35:
> https://hg.mozilla.org/integration/mozilla-inbound/rev/f42032325f18

Not sure what went wrong here, but it ended-up as a no-op. :( So I pushed it again:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c91a96c71e62

Given that we haven't seen any problems with the former patch, I'm going to release mozrunner 5.35 now.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Submitting dist/mozrunner-5.35.tar.gz to http://pypi.python.org/pypi
Server response (200): OK

Comment 11

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/f42032325f18
https://hg.mozilla.org/mozilla-central/rev/c91a96c71e62