Closed Bug 975312 Opened 6 years ago Closed 6 years ago

[mozrunner] Runner.check_for_crashes() should support save_path and quiet parameters

Categories

(Testing :: Mozbase, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla30

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

Attachments

(1 file, 1 obsolete file)

Right now the check_for_crashes() method of the Runner class does not support the save_path parameter of mozcrash. We have to get this added so that Mozmill can use it on bug 619204.
Test frameworks might not always want to let the information printed to stdout, but handle it on their own. So also forwarding the quiet parameter sounds important to me.
Summary: [mozrunner] Runner.check_for_crashes() should support save_path for storing minidump files → [mozrunner] Runner.check_for_crashes() should support save_path and quiet parameters
Attached patch Patch v1 (obsolete) — Splinter Review
I also pushed this to try:
https://tbpl.mozilla.org/?tree=Try&rev=00aa990af6bf
Attachment #8379648 - Flags: review?(ahalberstadt)
Attached patch Patch v1.1Splinter Review
Included the mozrunner version bump too.
Attachment #8379648 - Attachment is obsolete: true
Attachment #8379648 - Flags: review?(ahalberstadt)
Attachment #8379660 - Flags: review?(ahalberstadt)
Comment on attachment 8379660 [details] [diff] [review]
Patch v1.1

Review of attachment 8379660 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!
Attachment #8379660 - Flags: review?(ahalberstadt) → review+
Damn. Somehow I pushed the wrong patch to inbound which didn't include the version bump. :/ I will most likely do it later or wait until I'm back.
(In reply to Henrik Skupin (:whimboo) [away 02/24 - 02/28] from comment #8)
> Pushed version bump to 5.35:
> https://hg.mozilla.org/integration/mozilla-inbound/rev/f42032325f18

Not sure what went wrong here, but it ended-up as a no-op. :( So I pushed it again:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c91a96c71e62

Given that we haven't seen any problems with the former patch, I'm going to release mozrunner 5.35 now.
Submitting dist/mozrunner-5.35.tar.gz to http://pypi.python.org/pypi
Server response (200): OK
Keywords: leave-open
You need to log in before you can comment on or make changes to this bug.