Closed Bug 975343 Opened 6 years ago Closed 6 years ago

[DSDS] In Settings' "device information" page, we see only the informations for one SIM

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(blocking-b2g:1.4+, b2g-v1.4 fixed, b2g-v2.0 fixed)

VERIFIED FIXED
1.4 S5 (11apr)
blocking-b2g 1.4+
Tracking Status
b2g-v1.4 --- fixed
b2g-v2.0 --- fixed

People

(Reporter: julienw, Assigned: arthurcc)

References

Details

(Keywords: late-l10n)

Attachments

(4 files)

STR:
* open Settings
* tap Device Information
=> Only one phone number line is displayed. (and with my SIM it's marked "Unknown", which could be expected for my SIM)

* tap More Information
=> Only one ICCID information is displayed
This is the feature request since the display behavior is not defined by UX. Minus it for now and ni? UX for the spec.

Hi UX team,

Would you please help on the spec. about displaying the SIM2 information in this case?
blocking-b2g: 1.4? → ---
Flags: needinfo?(firefoxos-ux-bugzilla)
Duplicate of this bug: 975761
Flagging Carrie to clarify expected DSDS behavior.
Flags: needinfo?(firefoxos-ux-bugzilla) → needinfo?(cawang)
I think we missed this part in 1.3 and 1.4.
We shall display two phone numbers (SIM 1/ SIM 2) and also two ICCID in More information.
ni? Joe to see if we are going to implement this in 1.4.
ni? Fang for layout spec.

Thanks!
Flags: needinfo?(cawang) → needinfo?(fshih)
Flags: needinfo?(jcheng)
Hi Arthur, how difficult is it to implement this? if this is something relatively easy and safe, we can probably think about this. thanks
Flags: needinfo?(jcheng) → needinfo?(arthur.chen)
There is no big effort and should be safe.
Flags: needinfo?(arthur.chen)
Spec attached. Thanks!

* Two Phone numbers 
* ICCID information
Flags: needinfo?(fshih)
Asking 1.4? again on this, for DSDS consistency.
blocking-b2g: --- → 1.4?
Wilfred,

Can you prioritize for 1.4? Would this block 1.4?
Flags: needinfo?(wmathanaraj)
Since Wilfred is off, I'll try to make a decision here.  
If the phone number and ICCID only shows for SIM 1, regardless of how the SIM Manager calls are configured, then it is blocking.  
If it shows the phone number for whatever SIM is set to handle outgoing calls then it is probably a nice to have.

I'm going to block on it for now, assuming that the first scenario is true.  However, if that is not the case, please feel free to move to backlog.
blocking-b2g: 1.4? → 1.4+
Flags: needinfo?(wmathanaraj)
Hi Joe,

Is it possible to find one in your team to help on this feature? Arthur an EJ are already occupied by a number of blockers so far.
Flags: needinfo?(jcheng)
Joe,

Mind if you can give the update.
let's wait until next sprint to see if anyone has free cycles
Flags: needinfo?(jcheng)
Any update? Joe and Ivan. 
Who from your team can help? Thanks!
Flags: needinfo?(jcheng)
Flags: needinfo?(itsay)
Assignee: nobody → arthur.chen
Thanks Arthur as the firefighter to help on this late feature decision.
Flags: needinfo?(itsay)
Thanks, Ivan and Arthur.
Thanks Arthur
Flags: needinfo?(jcheng)
Status: NEW → ASSIGNED
Evelyn, could you help review the patch? Regarding the css, I hate to introduce a new class but that's the only way I can think of. Thanks!
Attachment #8400532 - Flags: review?(ehung)
Attached image phone_number.png
Attachment #8400538 - Flags: ui-review?(fshih)
Attached image iccid.png
Fang, could you help review the ui change? Thanks.
Attachment #8400539 - Flags: ui-review?(fshih)
Attachment #8400538 - Flags: ui-review?(fshih) → ui-review+
Comment on attachment 8400539 [details]
iccid.png

They are looking good!! Thanks!
Attachment #8400539 - Flags: ui-review?(fshih) → ui-review+
We're way past hard string freeze, can we expedite the review here, please?
Hey Evelyn, can you have a look to this 1.4+ issue?
Flags: needinfo?(ehung)
Comment on attachment 8400532 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/17885

Sorry I missed this review flag, I thought it's a Settings refactor bug.  r+, the patch is just query some information and manipulate DOM to display them properly. Thanks, Arthur.
Attachment #8400532 - Flags: review?(ehung) → review+
Flags: needinfo?(ehung)
Thanks, Evelyn!

master: 8515002c2c0712a83861558a5c76771e033b3f6d
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Comment on attachment 8400532 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/17885

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): DSDS
[User impact] if declined: Users are not able to see the iccid of the second icc card.
[Testing completed]: Manual testing completed and unit tests added.
[Risk to taking this patch] (and alternatives if risky): low
[String changes made]: Yes
Attachment #8400532 - Flags: approval-gaia-v1.4?(release-mgmt)
Comment on attachment 8400532 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/17885

No approval needed at this time for v1.4 blockers.
https://wiki.mozilla.org/Release_Management/B2G_Landing
Attachment #8400532 - Flags: approval-gaia-v1.4?(release-mgmt)
Backed out of 1.4 for causing unit test failures. Leaving as fixed, but marking 1.4 as affected and ni? on arthur to investigate. Please open a pull request with a patch against 1.4 and ensure travis is green before landing. Thanks!

https://github.com/mozilla-b2g/gaia/commit/9b2da43dfee3792cd311ae55f0b06272313208f0

Unit test errors:

 1) [settings] about > checkForUpdates > getting response for system update > check-error:

Error: expected 'check-error-http-200' to equal 'check-error-http-403'

at chaiAssert (http://settings.gaiamobile.org:8080/common/test/helper.js:33:1)

at equal (http://settings.gaiamobile.org:8080/common/vendor/chai/chai.js:1250:1)

at (anonymous) (http://settings.gaiamobile.org:8080/test/unit/about_test.js:191:11)

at wrapper (http://settings.gaiamobile.org:8080/common/test/mocha_generators.js:62:13)

at run (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3709:7)

at runTest (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4081:5)

at (anonymous) (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4127:7)

at next (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4007:7)

at (anonymous) (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4016:7)

at next (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3964:16)

at (anonymous) (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3984:5)

at (anonymous) (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4932:28)

2) [settings] about > checkForUpdates > getting response for system update > successful > remove the handler:

Error: expected [Function: onUpdateStatus] to equal undefined

at chaiAssert (http://settings.gaiamobile.org:8080/common/test/helper.js:33:1)

at equal (http://settings.gaiamobile.org:8080/common/vendor/chai/chai.js:1250:1)

at (anonymous) (http://settings.gaiamobile.org:8080/test/unit/about_test.js:157:11)

at wrapper (http://settings.gaiamobile.org:8080/common/test/mocha_generators.js:62:13)

at run (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3709:7)

at runTest (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4081:5)

at (anonymous) (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4127:7)

at next (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4007:7)

at (anonymous) (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4016:7)

at next (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3964:16)

at (anonymous) (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3979:7)

at done (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3700:5)

at (anonymous) (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3712:9)

at (anonymous) (http://settings.gaiamobile.org:8080/common/test/mocha_generators.js:46:13)

at wrapper (http://settings.gaiamobile.org:8080/common/test/mocha_generators.js:73:15)

at run (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3709:7)

at next (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3973:5)

at (anonymous) (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3984:5)

at (anonymous) (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4932:28)

3) [settings] about > checkForUpdates > getting response for app update > successful > remove the handler:

Error: expected [Function: onUpdateStatus] to equal undefined

at chaiAssert (http://settings.gaiamobile.org:8080/common/test/helper.js:33:1)

at equal (http://settings.gaiamobile.org:8080/common/vendor/chai/chai.js:1250:1)

at (anonymous) (http://settings.gaiamobile.org:8080/test/unit/about_test.js:216:11)

at wrapper (http://settings.gaiamobile.org:8080/common/test/mocha_generators.js:62:13)

at run (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3709:7)

at runTest (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4081:5)

at (anonymous) (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4127:7)

at next (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4007:7)

at (anonymous) (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4016:7)

at next (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3964:16)

at (anonymous) (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3979:7)

at done (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3700:5)

at (anonymous) (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3712:9)

at (anonymous) (http://settings.gaiamobile.org:8080/common/test/mocha_generators.js:46:13)

at wrapper (http://settings.gaiamobile.org:8080/common/test/mocha_generators.js:73:15)

at run (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3709:7)

at next (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3973:5)

at (anonymous) (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3984:5)

at (anonymous) (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4932:28)

4) [settings] SimSettingsHelper > SimSettingsHelper.setServiceOnCard("key", cardIndex) > SimPinLock > updateSimPinUI > icc has cardState, but not in airplane mode > will get right icc, exec onsuccess() and change UI:

Error: expected true to be false

at chaiAssert (http://settings.gaiamobile.org:8080/common/test/helper.js:33:1)

at get (http://settings.gaiamobile.org:8080/common/vendor/chai/chai.js:397:1)

at isFalse (http://settings.gaiamobile.org:8080/common/vendor/chai/chai.js:1385:5)

at (anonymous) (http://settings.gaiamobile.org:8080/test/unit/simcard_lock_test.js:256:9)

at wrapper (http://settings.gaiamobile.org:8080/common/test/mocha_generators.js:62:13)

at run (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3709:7)

at runTest (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4081:5)

at (anonymous) (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4127:7)

at next (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4007:7)

at (anonymous) (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4016:7)

at next (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3964:16)

at (anonymous) (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3979:7)

at done (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3700:5)

at (anonymous) (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3712:9)

at (anonymous) (http://settings.gaiamobile.org:8080/common/test/mocha_generators.js:46:13)

5) [settings] SimSettingsHelper > SimSettingsHelper.setServiceOnCard("key", cardIndex) > SimPinLock > addChangeEventOnIccs > one right iccId, one wrong iccId there is only one iccId works:

Error: expected false to be truthy

at chaiAssert (http://settings.gaiamobile.org:8080/common/test/helper.js:33:1)

at get (http://settings.gaiamobile.org:8080/common/vendor/chai/chai.js:352:1)

at ok (http://settings.gaiamobile.org:8080/common/vendor/chai/chai.js:1225:5)

at (anonymous) (http://settings.gaiamobile.org:8080/test/unit/simcard_lock_test.js:466:9)

at wrapper (http://settings.gaiamobile.org:8080/common/test/mocha_generators.js:62:13)

at run (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3709:7)

at runTest (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4081:5)

at (anonymous) (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4127:7)

at next (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4007:7)

at (anonymous) (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4016:7)

at next (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3964:16)

at (anonymous) (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3979:7)

at done (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3700:5)

at (anonymous) (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3712:9)

at (anonymous) (http://settings.gaiamobile.org:8080/common/test/mocha_generators.js:46:13)

at wrapper (http://settings.gaiamobile.org:8080/common/test/mocha_generators.js:73:15)

at run (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3709:7)

at next (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3973:5)

at (anonymous) (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3984:5)

at (anonymous) (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4932:28)

6) [settings] SimSettingsHelper > SimSettingsHelper.setServiceOnCard("key", cardIndex) > SimPinLock > addChangeEventOnIccByIccId > with right iccId > will register change event:

TypeError: returnValues[0] is undefined

at (anonymous) (http://settings.gaiamobile.org:8080/test/unit/simcard_lock_test.js:510:9)

at wrapper (http://settings.gaiamobile.org:8080/common/test/mocha_generators.js:62:13)

at run (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3709:7)

at runTest (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4081:5)

at (anonymous) (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4127:7)

at next (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4007:7)

at (anonymous) (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4016:7)

at next (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3964:16)

at (anonymous) (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3979:7)

at done (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3700:5)

at (anonymous) (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3712:9)

at (anonymous) (http://settings.gaiamobile.org:8080/common/test/mocha_generators.js:46:13)

at wrapper (http://settings.gaiamobile.org:8080/common/test/mocha_generators.js:73:15)

at run (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3709:7)

at next (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3973:5)

at (anonymous) (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3984:5)

at (anonymous) (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4932:28)

7) [settings] SimSettingsHelper > SimSettingsHelper.setServiceOnCard("key", cardIndex) > SimCardManager > updateCardState > not in airplane mode and with right iccId > "before each" hook:

TypeError: icc is undefined

at updateCardState (http://settings.gaiamobile.org:8080/js/simcard_manager.js:399:1)

at (anonymous) (http://settings.gaiamobile.org:8080/test/unit/simcard_manager_test.js:290:9)

at wrapper (http://settings.gaiamobile.org:8080/common/test/mocha_generators.js:62:13)

at run (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3709:7)

at next (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3973:5)

at (anonymous) (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3984:5)

at (anonymous) (http://settings.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4932:28)
Flags: needinfo?(arthur.chen)
Thanks Kevin!

Waiting for travis: https://github.com/mozilla-b2g/gaia/pull/18148
Flags: needinfo?(arthur.chen)
Travis is green.

v1.4: 6c50349f41d40ba175ea0fc0c2c2cbd739ba7170
Duplicate of this bug: 994462
Okay on Fugu v1.4

GAIA_REV=8dff633372022723e2ebad17fe3c826436b3b258
GECKO_REV=574e5ded8f4cd4f4177bbbbfea408e04ae66dddd
GAIA_BRANCH=mozillaorg/v1.4
GECKO_BRANCH=mozillaorg/v1.4
BUILD_TAG=jenkins-B2G.v1.4.0.fugu-23
BuildID=20140414041552
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.