Closed Bug 975504 Opened 10 years ago Closed 10 years ago

Allow filtering resources in Android Eclipse projects

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla30

People

(Reporter: nalexander, Assigned: nalexander)

References

Details

Attachments

(1 file)

Add filtered_resources to AndroidEclipseProjectData. r=bnicholson
8.54 KB, patch
bnicholson
: review+
Details | Diff | Splinter Review 
At the moment, resource files show up twice: once due to the src/ import, and once in the actual resource section.  Same with test files: once due to the src/ import, and once in the Robocop project.

Project > Filter > Filter Resources allows to ignore some of these; we should expose it to moz.build and use it for the Fennec project.
A reasonable review would be to skim the code and verify newly
generated project files can be imported.  You can check this is
working by using A-S-r (Open Resource) and verifying that Android
resources (*xml) appear in the list only once.
Attachment #8379883 - Flags: review?(bnicholson)
Assignee: nobody → nalexander
Comment on attachment 8379883 [details] [diff] [review]
Add filtered_resources to AndroidEclipseProjectData. r=bnicholson

Review of attachment 8379883 [details] [diff] [review]:
-----------------------------------------------------------------

WFM. Won't even bother asking what the magic numbers mean....
Attachment #8379883 - Flags: review?(bnicholson) → review+
https://hg.mozilla.org/mozilla-central/rev/6d99d4df5e4f
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.