975525 - Refresh actionview icons if the GeckoActionProvider has changed

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect)

Description

[Wesley Johnston (:wesj)]

Split off from bug 881861.

Comment 1

[Wesley Johnston (:wesj)]

Attachment: Patch

mfinkle r+ in the original bug. Just split this off to avoid confusion in uplift/tracking bugs. I'll land this on central.

Comment 2

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/fx-team/rev/95849d209a1f

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/95849d209a1f

Comment 4

[Wesley Johnston (:wesj)]

backed out 069f663e7e64

Comment 5

[Wesley Johnston (:wesj)]

err... https://hg.mozilla.org/integration/fx-team/rev/069f663e7e64

Comment 6

[Aaron Train [:aaronmt]]

Backed out on suspicion of causing crash bug 975838

Comment 7

[Aaron Train [:aaronmt]]

Confirming Nightly (02/25) is better

Comment 8

[Ryan VanderMeulen [:RyanVM]]

(In reply to Aaron Train [:aaronmt] from comment #7)
> Confirming Nightly (02/25) is better

Interesting! Given:

Merge of backout.
https://hg.mozilla.org/mozilla-central/rev/069f663e7e64

:)

Comment 9

[Wesley Johnston (:wesj)]

Unassigning. But I'll point mcomella at this since he's been in here a bit.

Comment 10

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Not sure what this is about. Can we close this or is it still valid?

Comment 11

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

I think this means the quick share items in the 3-dot menu currently don't update if the back-end changes (except by sharing).

That being said, I haven't heard anyone reference this issue to me besides comment 9 so I don't think it's worth the added code complexity at the moment – WONTFIX.