Closed
Bug 975618
Opened 11 years ago
Closed 11 years ago
importLiveOption and importGmail option seem backwards
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.4 S4 (28mar)
People
(Reporter: kats, Assigned: fcampo)
Details
Attachments
(1 file)
See https://github.com/mozilla-b2g/gaia/blob/b0345f4c8c62b590e81c0f409639f9a259e86b47/apps/communications/contacts/js/views/settings.js#L103 and line 104. importLiveOption grabs the gmail div and vice-versa.
|
||
Comment 1•11 years ago
|
||
w00t!!!
Thanks for spotting it!
|
||
Updated•11 years ago
|
Assignee: nobody → fernando.campo
|
Assignee | |
Comment 2•11 years ago
|
||
Attachment #8389126 -
Flags: review?(jmcf)
|
|
||
Updated•11 years ago
|
OS: Mac OS X → Gonk (Firefox OS)
Hardware: x86 → ARM
|
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8389126 [details] [review]
Link to PR - https://github.com/mozilla-b2g/gaia/pull/17071
thanks for fixing and for the tests
Attachment #8389126 -
Flags: review?(jmcf) → review+
|
|
||
Comment 4•11 years ago
|
||
landed in master:
https://github.com/mozilla-b2g/gaia/commit/36150454b387fe75074cbd8b20eb395dde154471
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
Target Milestone: --- → 1.4 S4 (28mar)
You need to log in
before you can comment on or make changes to this bug.
Description
•