Closed Bug 975654 Opened 10 years ago Closed 10 years ago

[B2G][l10n][Email] Disabling IMAP on a Gmail account exposes user to old UI which is globally not translated

Categories

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(b2g-v1.2 affected, b2g-v1.3 affected)

VERIFIED FIXED
1.4 S2 (28feb)
Tracking Status
b2g-v1.2 --- affected
b2g-v1.3 --- affected

People

(Reporter: pbylenga, Assigned: mcav)

Details

(Keywords: l12y, Whiteboard: locrun1.3 [p=3])

Attachments

(3 files)

Attached image Gmail_IMAP_Disabled.png
Description:
If a user disables IMAP on an already setup Gmail account they are presented with old UI.

Repro Steps:
1) Update a Buri to BuildID: 20140221004002
2) Setup a Gmail account with the Email App
3) On desktop disable IMAP on the respective Gmail Account
4) On Buri launch Email app again or attempt a sync and observe

Actual:
User is exposed to old ui of IMAP being disabled error.

Expected:
User is presented with new v1.3 design of error message that IMAP has been disabled.

v1.3 Environmental Variables:
Device: Buri v1.3 MOZ
BuildID: 20140221004002
Gaia: 8039a5cb7519adfa81677df577f494c6a4de6140
Gecko: e5f25becc0e7
Version: 28.0
Firmware Version: v1.2-device.cfg


Notes:

Repro frequency: 5/5, 100%
See attached: screenshot
This issue reproduces on v1.2

v1.2 Environmental Variables:
Device: Buri v1.2 MOZ
BuildID: 20140220004002
Gaia: 539a25e1887b902b8b25038c547048e691bd97f6
Gecko: 2ea6a65eea23
Version: 26.0
Firmware Version: v1.2-device.cfg
If UI is kept, it affects localization as none of the strings on this screen are translated when Device language is set to the following languages:

bg/ Bulgarian/ България
zh-CN/ Simplified chinese/ 
it/ Italian/ Italiano
mk/ Macedonian/ Македонски јазик
zh-TW / Chinese (Traditional)  /正體中文 (繁體)
ca/ Catalan/ català
cs/ Czech/ Čeština
de/ German/ Deutsch
el/ Greek/ ελληνικά
es/ Spanish/ español
hr/ Croatian/ Hrvatski
hu/ Hungarian / Magyar
nl/ Nederlands/ Dutch/ Nederlands
pl/ Polish / Polski
pt-Br/ Portuguese-Brazil/ Portugues
ro/ Romanian/ română
ru/ Russian/ Русский
sk/ Slovak/ slovenčina
sr-Cyrl/ Serbian Cyrillic/ српски
sr-Latn/ Serbian Latin/ srpski
tr/ Turkish/ Türkçe
bn-BD/ Bengali (বাংলা)
Keywords: l12y
Summary: [B2G][Email] Disabling IMAP on a Gmail account exposes user to old UI → [B2G][l10n][Email] Disabling IMAP on a Gmail account exposes user to old UI which is globally not translated
Whiteboard: locrun1.3
Is this something UX can fix? Not sure where this comes from
Asking for more info
Flags: needinfo?(firefoxos-ux-bugzilla)
I don't think this requires UX involvement; the styling changes that were landed for e-mail didn't update this card (and probably some of our similar cards), and there's clearly a bug with our failure to localize these cards.

And that bug appears to be a typo in setup_fix_gmail.js.  "textCountent" with a 'u' got used instead of textContent.  This appears localized to that one card.

The git log blames bug 832924's landing, but that surprises me a little bit.  Ideally we'd change the code to just use mozl10n.localize(elem, l10-id) instead when fixing this so we can stop typing textContent and have magic updating translations too.
Flags: needinfo?(firefoxos-ux-bugzilla)
Oh wow, that's silly. Will update with mozl10n.localize and such.
Assignee: nobody → m
Status: NEW → ASSIGNED
Target Milestone: --- → 1.4 S2 (28feb)
Here's the patch. Rather than mucking about with a fake Gmail account, I just replaced one of the calls to Cards.pushCard with the gmail card, resulting in the following screenshot to show that the translations are actually fixed now.

http://cl.ly/image/2N3E1Z07093o

(obviously placement is weird because I selected a weird invocation of pushCard)
Attachment #8381572 - Flags: review?(bugmail)
Comment on attachment 8381572 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16630/files

fyi/future: bugzilla doesn't like "/files" in the URL; the github detecting regex becomes sad

Your choice of pushCard invocation is indeed silly, but thanks for going the extra mile to provide the screenshot too  (Although I realize as an OS X user you've probably got super-easy-to-use thing in your menu bar or awesome quicksilver helper or something!)

Great cleanup on the patch, too.
Attachment #8381572 - Flags: review?(bugmail) → review+
Whiteboard: locrun1.3 → locrun1.3 [p=3]
Landed:

https://github.com/mozilla-b2g/gaia/commit/1a33ed848bb2e8781f6359da17e1de0282cb3e17
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Hi Team,

Although the bug has fixed, but the text and button does not align center. Please see the attachment.

[Environment]

Gaia      71f78f7f68fcf5e23cc5965fee0dad45289c438b
Gecko     https://hg.mozilla.org/mozilla-central/rev/5dc091b7e86f
BuildID   20140304160205
Version   30.0a1

[Steps]
1. Launch email app and set a gmail account with Gmail.
2. Make sure that it can receive mails.
3. Go desktop of gmail setting to disable IMAP.
4. Close email app
5. Launch email app again, and then waiting for 1 min. 
6. Show "IMAP Disable" page.

[Actual result]
The text as well as button has not center-text.

[Expect result]
The text as well as button has center-text.

[Result]
Failed. I reopen it.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Since we fixed the l10n issue (which was the more urgent bit), please spin off a new bug just about the visual problems that remain with the card.  Thanks!
Status: REOPENED → RESOLVED
Closed: 10 years ago10 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: