975771 - getUserMedia debug-only crash [@ nsXPCWrappedJS::AddRef()]

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Jesse Ruderman]

Attachment: testcase

Afaict, any use of mozGetUserMedia in a debug build crashes the browser. I have no idea why regression tests didn't catch this.

This is a recent regression, maybe from bug 968836.

Comment 1

[Jesse Ruderman]

Attachment: stack

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Caused by bug 968836

Comment 3

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

(In reply to Jesse Ruderman from comment #0)
> Afaict, any use of mozGetUserMedia in a debug build crashes the browser. I
> have no idea why regression tests didn't catch this.

MediaManager has a different code-path for the permission prompt than for when the permission prompt is disabled like it is on the builders. This crash is in the permission prompt code-path.

Comment 4

[Maire Reavy [:mreavy]]

Jib -- Can I assign this to you?

Comment 5

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

I agree with Randell in comment 2 that this was caused by patch in Bug 968836 which has since been backed out. I can't reproduce now. Can we close as fixed?

Comment 6

[Maire Reavy [:mreavy]]

(In reply to Jan-Ivar Bruaroey [:jib] from comment #5)
> I agree with Randell in comment 2 that this was caused by patch in Bug
> 968836 which has since been backed out. I can't reproduce now. Can we close
> as fixed?

Yes, let's close.  Thanks, Jan-Ivar.