Add FHR search source for about:newtab

VERIFIED FIXED in Firefox 31

Status

defect
VERIFIED FIXED
5 years ago
8 months ago

People

(Reporter: adw, Assigned: adw)

Tracking

unspecified
Firefox 31
Dependency tree / graph
Bug Flags:
firefox-backlog +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: p=2 s=it-32c-31a-30b.1 [qa!])

Attachments

(1 attachment, 1 obsolete attachment)

Assignee

Description

5 years ago
Bug 962490 will add a search field to about:newtab pretty much like about:home's.  The patch I'm about to post there does this:

> browserWin.BrowserSearch.recordSearchInHealthReport(engine, "aboutnewtab");

From what I gather looking at about:home's implementation, that's all that's necessary from the front-end.

I'm happy to help where possible.  I see services/healthreport/providers.jsm.  What else does this involve?
You also need to add the new source to the provider. about:netError just did exactly this -- you should be able to use Bug 966107 as inspiration, and to check that it works. Either gps or myself can review.
Assignee

Comment 2

5 years ago
Posted patch patch (obsolete) — Splinter Review
I don't know whether the amazon.com.newtab, etc. changes are necessary.  This also updates the test.  It seems to work: when I do a Google search on about:newtab, this shows up in about:healthreport's raw data:

"org.mozilla.searches.counts": {
  "_v": 3,
  "google.newtab": 1,
},
Assignee: nobody → adw
Status: NEW → ASSIGNED
Attachment #8381041 - Flags: review?(rnewman)
Comment on attachment 8381041 [details] [diff] [review]
patch

Review of attachment 8381041 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with the SCM1 changes removed. Thanks!

::: services/healthreport/providers.jsm
@@ +1246,2 @@
>    name: "counts",
>    version: 1,

You don't need to touch SearchCountMeasurement1; no new data is being recorded for this measurement.
Attachment #8381041 - Flags: review?(rnewman) → review+
Assignee

Comment 4

5 years ago
Thanks.

Pedantic meta note: Normally I'd just land with review comments addressed, but I'm posting the revised patch and carrying over the r+ because bug 962490 was just placed on the back burner, which makes me uncertain when/whether we'll need this bug, so I'll keep this here until we do need it.
Attachment #8381041 - Attachment is obsolete: true
Attachment #8381720 - Flags: review+
Flags: firefox-backlog?
Flags: firefox-backlog? → firefox-backlog+
Whiteboard: p=0
https://hg.mozilla.org/mozilla-central/rev/36b040d46b79
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 31
Hi Drew, can you provide a point estimate for this bug.
Flags: needinfo?(adw)
Whiteboard: p=0 → p=0 s=it-31c-30a-29b.3 [qa?]
Assignee

Updated

5 years ago
Flags: needinfo?(adw)
Whiteboard: p=0 s=it-31c-30a-29b.3 [qa?] → p=2 s=it-31c-30a-29b.3 [qa?]
QA Contact: kamiljoz
Whiteboard: p=2 s=it-31c-30a-29b.3 [qa?] → p=2 s=it-31c-30a-29b.3 [qa+]
Whiteboard: p=2 s=it-31c-30a-29b.3 [qa+] → p=2 s=it-32c-31a-30b.1 [qa+]
Verified fixed on Mac OS X 10.9, Windows 7 64bit, Windows 8.1 32bit and Ubuntu 13.04 using:
1. Latest Fx 31 Aurora, build ID: 20140508004006
2. Latest Fx 32 Nightly, build ID: 20140508030203

On the about:healthreport page, under Raw Data, the "google.newtab" counter from "org.mozilla.searches.counts" keeps increasing after each search made on the newtab page. Verified with more than 50 searches. 
Also verified that the searches made from the searchbar and the urlbar have separate counters and does not interfere with the ones from the newtab page.
 
User Agents:
1. Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Firefox/31.0
   Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Firefox/31.0
   Mozilla/5.0 (Windows NT 6.3; rv:31.0) Gecko/20100101 Firefox/31.0
   Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Firefox/31.0

2. Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:32.0) Gecko/20100101 Firefox/32.0
   Mozilla/5.0 (Windows NT 6.1; WOW64; rv:32.0) Gecko/20100101 Firefox/32.0
   Mozilla/5.0 (Windows NT 6.3; rv:32.0) Gecko/20100101 Firefox/32.0
   Mozilla/5.0 (X11; Linux i686; rv:32.0) Gecko/20100101 Firefox/32.0
Status: RESOLVED → VERIFIED
QA Contact: kamiljoz → cornel.ionce
Whiteboard: p=2 s=it-32c-31a-30b.1 [qa+] → p=2 s=it-32c-31a-30b.1 [qa!]

Updated

8 months ago
Product: Firefox Health Report → Firefox Health Report Graveyard
You need to log in before you can comment on or make changes to this bug.