Closed Bug 975789 Opened 6 years ago Closed 6 years ago

"ASSERTION: Stacking contexts must also be pseudo-stacking-contexts" with will-change, table

Categories

(Core :: Layout, defect)

x86_64
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: jruderman, Assigned: bjacob)

References

(Blocks 1 open bug)

Details

(Keywords: assertion, testcase)

Attachments

(3 files)

Attached file testcase
With
  user_pref("layout.css.will-change.enabled", true);

###!!! ASSERTION: Stacking contexts must also be pseudo-stacking-contexts: '!isStackingContext || pseudoStackingContext', file layout/generic/nsFrame.cpp
Attached file stack
Attached patch fixSplinter Review
Attachment #8383199 - Flags: review?(dbaron)
Comment on attachment 8383199 [details] [diff] [review]
fix

Please also add an "if you change this, also change" comment in the other direction.

r=dbaron with that, although there are some other annoying inconsistencies between the two pieces of code that should probably be investigated
Attachment #8383199 - Flags: review?(dbaron) → review+
Landed with the requested comment.

Yes, and it seems that the approach of having one big logical expression won't scale anyway, will probably need to be split into separate statements at some point.

https://hg.mozilla.org/integration/mozilla-inbound/rev/1b4c49b07790
Assignee: nobody → bjacob
https://hg.mozilla.org/mozilla-central/rev/1b4c49b07790
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.