975808 - When hovering over disabled 'Bookmark this site' button the 'Bookmark menu' button gets hovering state set

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Sami Jaktholm]

Attachment: Image of incorrect hovering state

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:30.0) Gecko/20100101 Firefox/30.0 (Beta/Release)
Build ID: 20140223123707

Steps to reproduce:

1. Open about:newtab (the 'Bookmark this site' is disabled there).
2. Hover over 'Bookmark this site' button.


Actual results:

The button next to it, 'Show bookmarks' is styled as it was being hovered over.


Expected results:

Nothing. The style of neither button shouldn't have changed.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/integration/fx-team/rev/8187e4139690

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8187e4139690

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8387099 [details] [diff] [review]
Patch v1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 

Australis!


User impact if declined: 

Potential for experiencing UI glitch on Linux where hovering a disabled bookmark star causes the hover state of the bookmarks menu button dropmarker to manifest. See screenshot. It just looks sloppy.


Testing completed (on m-c, etc.): 

Plenty of local testing.


Risk to taking this patch (and alternatives if risky): 

Very, very low.


String or IDL/UUID changes made by this patch:

None!

Comment 5

[Mike Conley (:mconley) (:⚙️)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/3324a1e09336

Comment 6

[Andrei Vaida [:avaida]]

This issue is no longer reproducible on Firefox 29.0 (Build ID: 20140407135746), Aurora 30 (2014-04-23) and Nightly 31 (2014-04-23), using:
- Ubuntu 12.04 32-bit [1],
- Windows 7 64-bit [2],
- Mac OS X 10.9 [3].