Closed Bug 975868 Opened 12 years ago Closed 11 years ago

Update MDN's CKEditor to 4.x

Categories

(developer.mozilla.org Graveyard :: General, defect)

Product:
developer.mozilla.org Graveyard
Component:
General
Platform:
All
Other
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: sheppy, Unassigned)

References

Details

(Whiteboard: [specification][type:change])

What feature should be changed? Please provide the URL of the feature if possible. ================================================================================== We are currently using a 2-year-old version of CKEditor on MDN. We need to update to be current. What problems would this solve? =============================== This will let us take advantage of new features and plugins that will likely help us fix various bugs more easily. Who would use this? =================== All users. What would users see? ===================== New, shiny editor. What would users do? What would happen as a result? =================================================== No change. Is there anything else we should know? ====================================== This will break several plugins, so those will need updating or replacing. Some may not be necessary anymore, or can be replaced with new ones from CKSource. Others will just need rewriting. This isn't a small job.
Blocks: 1032827
Commits pushed to ckeditor-update-updates at https://github.com/mozilla/kuma https://github.com/mozilla/kuma/commit/b3c5974646e31e22c154ed96204f2bcd84df7348 bug 975868 - Adding CKEditor post-build files, documentation for how to build CKE https://github.com/mozilla/kuma/commit/c7754f98787ffeaa6e743bf88d54f5e8f6d3dff8 bug 975868 - Add new document to index
Commits pushed to ckeditor-update-updates-messages at https://github.com/mozilla/kuma https://github.com/mozilla/kuma/commit/940c32ea0b776799e2027a26c03fb4b49f8ac6b9 bug 975868 - Started CKEditor v3 to v4 updated. * Moved CKEditor v3 files to ckeditor-old directory. * Added CKEditor v4, SCAYT, WSC submodules. * Added CKEditor build script and build config. https://github.com/mozilla/kuma/commit/aa70c202118c2c54f1e3dda3d2d12233b4badd8d bug 975868 - Added custom CKEditor 4.3.3 build. https://github.com/mozilla/kuma/commit/d5621b5d466c9fe0598cd6e6cd59e9574c884c2b bug 975868 - Started updating CKEditor config to match v4. * Commented out the floating toolbar code - that needs to be implemented in different way in v4. * New HTML5 elements had been added to CKEditor DTD, so the fix for <time> is not necessary any more. * config.dialog_noConfirmCancel replaced hack used to prevent displaying confirm popups on dialog cancel. * Since custom CKEditor build is used there's no need to disable resize by a config option (because plugin isn't enabled at all). * Commented out incompatible toolbar and plugins configuration - they will be brought back following commits. https://github.com/mozilla/kuma/commit/03aa480b59bdd29e9785d64c4a56b94cb20b36df bug 975868 - Made it possible to easily switch between dev and production verion of CKEditor. https://github.com/mozilla/kuma/commit/a42893c605a02f155d0c1851d3d5b8c9baa48334 bug 975868 - Ported format buttons from old mdn-buttons plugin. https://github.com/mozilla/kuma/commit/e6be5959df1c6d80640542994994cdc09f7e7557 bug 975868 - Ported save and preview buttons from old mdn-buttons plugin. https://github.com/mozilla/kuma/commit/8ee8322acd2b7f99b314fb25f207d3b2e343e405 bug 975868 - Ported syntaxhighlighter plugin. https://github.com/mozilla/kuma/commit/195e20521ab0e303ff350ad33502b5005e75c13d bug 975868 - Ported mdn-keystrokes. * Keystrokes to command mapping landed in config.js. * Blocked keystrokes landed in config.js as well. * Toggle block command extracted to mdn-toggle-command plugin. * Custom tab key functionality replaced by CKEditor's tab plugin and indentlist. It might not be 1:1 change, but the rest of custom tab handling seemed to be broken or unmaintainable. https://github.com/mozilla/kuma/commit/db77589e03bde29e8afe82ccaa48af1b728e6d48 bug 975868 - Ported mdn-sampler plugin. https://github.com/mozilla/kuma/commit/b34457fe75a4298b32c99c00bc0b748fe4bcb845 bug 975868 - Copied tablesort plugin from CKEditor 3 to 4. https://github.com/mozilla/kuma/commit/9fc9890ab57b8850cc15fd6c7464b18e253494c1 bug 975868 - Aligned tablesort's lang file to CKE4. https://github.com/mozilla/kuma/commit/dc1f8cd793baaa966a4c5eb2509b32a371d4e0a4 bug 975868 - Updated custom CKEditor build. https://github.com/mozilla/kuma/commit/0dd18a6a9e8f8f04d71e4ee101b728158c7cfef8 bug 975868 - Pieces we hopefully don't need any more. https://github.com/mozilla/kuma/commit/167419ba4da114a0bde25832eea8e48b3935df29 bug 975868 - Ported mdn-redirect plugin. https://github.com/mozilla/kuma/commit/e56b4a381643f79f75e709793c09b05b0907cbcc bug 975868 - Updated CKEditor and its requirements submodules HEADs to 4.4.0. https://github.com/mozilla/kuma/commit/5463b391ce6f3b4c0dbe29e095a4479efa64cd67 bug 975868 - Rebuilt CKEditor. https://github.com/mozilla/kuma/commit/e0c8112435f8f8a3d2b5abc814002951ea3476f5 bug 975868 - Ported mdn-attachments. https://github.com/mozilla/kuma/commit/c88233445bbebf9f91f33b77f81328df99fdb781 bug 975868 - Ported mdn-sample-finder plugin. https://github.com/mozilla/kuma/commit/b28ccf71309f03e01a55a7fde331ddfa5b85da56 bug 975868 - Merge branch 'master' into ckeditor-update Conflicts: .gitignore kuma/wiki/templates/wiki/ckeditor_config.js media/redesign/stylus/wiki-edit.styl https://github.com/mozilla/kuma/commit/caea50e0030d832245c130b48a854ada777e527e bug 975868 - After merge fixes - brought back changes made to ckeditor_config.js on master between e2eb07263 and 735db76. https://github.com/mozilla/kuma/commit/ae8c66938aa9d6e9fc27ab2bcc1ebd5768109adc bug 975868 - Upgraded CKEditor and plugins to 4.4.4. https://github.com/mozilla/kuma/commit/4126404c840fa6a250ae0525c660e0d59483e5a8 bug 975868 - Rebuilt CKEditor. https://github.com/mozilla/kuma/commit/7cd6cc4beaf25d82ef186bf9d32a8a68ca4235b0 bug 975868 - Changed format of URLs to submodules. https://github.com/mozilla/kuma/commit/fdda4b7333b725a00d30ad20d01ec570bf587a4e bug 975868 - Added Reinmar/ckeditor-descriptionlist plugin as a replacement of old definitionlist plugin. https://github.com/mozilla/kuma/commit/61f338fa64ceb03c1b50e1aee920ac9b453d9444 bug 975868 - Extracted mdn-link-launch plugin from old mdn-link. https://github.com/mozilla/kuma/commit/d38c56a798c8a61d82fe772d042f5660cf431a36 bug 975868 - MDN's enter key plugin isn't needed any more. It contained special cases for definitionlist plugin. Current descriptionlist plugin handles these cases by itself. https://github.com/mozilla/kuma/commit/b90334aeab3d0e4c0cb47e77a993067aae5787b6 bug 975868 - Extracted mdn-table-customization plugin from old mdn-table plugin. https://github.com/mozilla/kuma/commit/4448b757cfe5d926d79149d2ac9a751f8d31ad87 bug 975868 - Rebuilt CKEditor. https://github.com/mozilla/kuma/commit/79977c384f14ad2932f7cf45487414daec818383 bug 975868 - Improved the way how table dialog is customised. https://github.com/mozilla/kuma/commit/54eb2a1d7789a2c38117d4f09bdb13f4824fbdfe bug 975868 - Portex texzilla plugin. https://github.com/mozilla/kuma/commit/be5792288c01eb0bda0685810b7e0b8150aae299 bug 975868 - Ported Youtube plugin. https://github.com/mozilla/kuma/commit/0f04cee0ef7a0b18b158b93368f4ca45c6dbda0e bug 975868 - Ported textzilla's icon. https://github.com/mozilla/kuma/commit/19491e3758eb1de41270e73c67ce808fe9f883a6 bug 975868 - Old browsers will fail on default used as a property name. https://github.com/mozilla/kuma/commit/c104c8b228644d7e5eb036835b66e1085a0acd2e bug 975868 - Rebuilt CKEditor. https://github.com/mozilla/kuma/commit/26cdb9b802062e7fc772abcaff26f5fd101fd3d0 bug 975868 - Added youtube's and textilla's icons in a way that CKBuilder can find and optimize them. https://github.com/mozilla/kuma/commit/0b530d7dad436d757924ddb7a226bf0b51d83778 bug 975868 - Rebuilt CKEditor. https://github.com/mozilla/kuma/commit/0a3f599f060da8cbd8a5164028ce7bed97509b31 bug 975868 - Ported mdn-spell plugin. https://github.com/mozilla/kuma/commit/c28971de25e43827a757460ab6af4aafedbd8d24 bug 975868 - Extracted modifications from mdn-image to mdn-image-attachment. https://github.com/mozilla/kuma/commit/5619e62b6816543adf3f4832203a5f72a3fcbf68 bug 975868 - Ported mdn-wrapstyle plugin. https://github.com/mozilla/kuma/commit/6597d92f7f57c0112f7a7542308f24fa1168e0d4 bug 975868 - Extracted changes from mdn-link plugin to a separate plugin. https://github.com/mozilla/kuma/commit/28cb5190406a68880156e4bbb64b3df90f1ca422 bug 975868 - Updated CKEditor submodule to 4.4.5. https://github.com/mozilla/kuma/commit/bd8d683ae59c52c55de46d34a966b64c696e0e36 bug 975868 - Rebuilt CKEditor prod version. https://github.com/mozilla/kuma/commit/fd0fb5b5258c712b2f23442cb645528dd6074007 bug 975868 - Implemented sticky toolbar. https://github.com/mozilla/kuma/commit/04849c55581e5a0d00b7ef40b91578c0629bbafa bug 975868 - Added vertical padding in the editing area. https://github.com/mozilla/kuma/commit/3f99dbb83fd82788919ce026e13c76c9330372c4 bug 975868 - Reorganized buttons in the toolbar. https://github.com/mozilla/kuma/commit/d50918a71c6e78731058f53148aceb3ce2ad1206 bug 975868 - Updated CSS selectors for save and preview buttons. https://github.com/mozilla/kuma/commit/f72d534e2a3a0b9eb76112fbe33a22812d04cf67 bug 975868 - Made styles drop down button and panel bigger. https://github.com/mozilla/kuma/commit/282303047acfbc2cc18f053c788c7d32df912f48 bug 975868 - Rebuilt CKEditor. https://github.com/mozilla/kuma/commit/ded36d8dfb531dd137c63a790a33199c737c1039 bug 975868 - Merge branch 'master' into ckeditor-update Conflicts: kuma/wiki/templates/wiki/ckeditor_config.js https://github.com/mozilla/kuma/commit/384d6b80ebd6b5bc17fdc09fc1d580b353624289 bug 975868 - Ported changes committed to master. https://github.com/mozilla/kuma/commit/004c71889d2c14d2906db0b26faa089787ba19cb bug 975868 - Ported some icons from the v3 and created some new. https://github.com/mozilla/kuma/commit/4176481f2f4297d17c21dda15cf6512e2a2aab97 bug 975868 - Desaturated icons ported from v3. https://github.com/mozilla/kuma/commit/b508dd04852192659299fd9cb46162421994a448 bug 975868 - Rebuilt CKEditor. https://github.com/mozilla/kuma/commit/faa20fd508f8fd44bc3fda843a55d8666fb9936b bug 975868 - Merge remote-tracking branch 'upstream/master' into ckeditor-update https://github.com/mozilla/kuma/commit/4aa673b6954a9ca0a469615f1b50b599e83fe4f8 bug 975868 - Merge remote-tracking branch 'upstream/master' into ckeditor-update https://github.com/mozilla/kuma/commit/649571e21b09b7f7b35107856bbb9437f958eb46 bug 975868 - Removed CKEditor 3 sources. https://github.com/mozilla/kuma/commit/7e4079444124680df363e58d57a33eed278477da bug 975868 - Updated descriptionlist plugin repository name. https://github.com/mozilla/kuma/commit/c1fef624e54ba856310841b0d1e3defae9e46bd4 bug 975868 - Updated descriptionlist plugin submodule HEAD. https://github.com/mozilla/kuma/commit/835a191848d210f929cd9a4b87c46f79639dc4c4 bug 975868 - Merge branch 'ckeditor-update' of https://github.com/Reinmar/kuma into ckeditor-update-updates https://github.com/mozilla/kuma/commit/ec9b0781f850747c2eabeb271038ca214b14d4ce bug 975868 - bug 975868 - Adding CKEditor post-build files, documentation for how to build CKE https://github.com/mozilla/kuma/commit/ecdbeb43684535a8d2c440bdaa3e32798c4a5c92 bug 975868 - bug 975868 - Add new document to index https://github.com/mozilla/kuma/commit/77c6b308c3e0dfee30a76b97851b74d097cb2a10 bug 975868 - Started CKEditor v3 to v4 updated. https://github.com/mozilla/kuma/commit/1d71275897b8861f741ce7f10de9a3c4db357d12 bug 975868 - Add built version of CKE https://github.com/mozilla/kuma/commit/bbf494d75bf39a1d6d272b32793fe7062e93974b bug 975868 - Switch to built version of CKE in template
Commit pushed to ckeditor-update-updates-messages at https://github.com/mozilla/kuma https://github.com/mozilla/kuma/commit/481e81a5a929c27df23ad5478512850d04c5608c bug 975868 - Updating submodule for plugins
Commit pushed to ckeditor-update-updates-messages at https://github.com/mozilla/kuma https://github.com/mozilla/kuma/commit/840f14ef6230ad8596f326059eee5e2f377ca03f bug 975868 - Update submodule for descriptor-list to no longer require submodule
Commit pushed to ckeditor-update-updates-messages at https://github.com/mozilla/kuma https://github.com/mozilla/kuma/commit/fd7214b83a399b7e72069c93cf07db3d1ecc99b9 bug 975868 - Update descriptor-list submodule commit
Commits pushed to ckeditor-update-updates-messages at https://github.com/mozilla/kuma https://github.com/mozilla/kuma/commit/95c00c43123ce09a1f2eb4129de01c0d5b4042b2 bug 975868 - Remove plugin submodules from CKE https://github.com/mozilla/kuma/commit/0f14e6fc3a7ecbd1d9eeaa3453cb1e96b8ee221b bug 975868 - Update build script with custom plugins, commit new build
Commit pushed to ckeditor-update-updates-messages at https://github.com/mozilla/kuma https://github.com/mozilla/kuma/commit/21049d95bb582837f44182dfd6d57d78eb0ff203 bug 975868 - Update build script with CKEditor checkout, remove its submodule
Commit pushed to ckeditor-update-updates-messages at https://github.com/mozilla/kuma https://github.com/mozilla/kuma/commit/80cdb0766d3bcf45c7846e13eb25b7b920234350 bug 975868 - Remove spellcheck plugin which isn't being used
I'd like to formally request review of the CKEditor upgrade on MDN. CKEditor is a WYSIWYG editor which allows our contributors to write rich text documentation from within the browser. This contribution has been made by the CKEditor project lead developer via this pull request: https://github.com/mozilla/kuma/pull/2948 When the security review begins, I will place this contribution on our staging server (http://developer.allizom.org). The CKEditor can be seen in 3 places (new, edit, and translate): https://developer.allizom.org/en-US/docs/new (empty content) https://developer.allizom.org/en-US/docs/Web$edit (prepopulated content) https://developer.allizom.org/es/docs/Web$edit (prepopulated content) We should be on the lookout for XSS and stored XSS issues, as well as the usual front-end security issues. Per the review request process (https://wiki.mozilla.org/WebAppSec/Security_Review_Request#Security_Assurance_Vendor_Review_Request) form: Overall ================ Please describe the overall purpose of the system and how Mozilla data will be integrated ---------------------------- CKEditor is required for our users to create and edit rich content. The editor is placed into the page with JavaScript. On "edit" and "translate" pages, the editor is prepopulated with HTML content which has *not* been modified or scrubbed, so if a user attempts an XSS, that XSS-containing content is placed within the editor. We should ensure the XSS code is not executed. Security Management ================ Have you performed internal security audits of your code or application that, at a minimum, addressed the OWASP Top 10? If so, please provide a description of the review and results. ---------------------------- I have not specifically, outside of basic testing. Has a security audit been performed by an external third party? If so, who performed this audit and are the results available? ---------------------------- CKEditor does not publish a detailed security document or set of standards. Searching for "CKEditor security" and "CKEditor secure" shows a record of specific security releases. How do you protect Mozilla data that will be stored on your servers or within your applications? ---------------------------- MDN stores *exact*, non-scrubbed content within the database. Before any content is displayed on a wiki page, the content is scrubbed. When the content is placed in the CKEditor, however, non-scrubbed content is placed within the textarea which CKEditor uses. CKEditor takes that data and places it within its content IFRAME. We rely on CKEditor to prevent the execution of said XSS issues. How do you prevent other customers of your service from obtaining access to data provided by Mozilla? ---------------------------- MDN is an open book. Content is avialable on wiki pages, via CORS, an API, etc. What is your disclosure policy to customers in the event of a compromise of your servers, applications or any related infrastructure that interacts with the applications holding Mozilla data? ---------------------------- During a past security issues, a blog post on the Mozilla blog was completed, as well as a notification in the heading of the site. That was for a PII issue with an unsecured database dump. Have you suffered a security compromise in the past 24 months? If so, please provide details and remediation that occurred as a result. ---------------------------- Yes: https://blog.mozilla.org/security/2014/08/01/mdn-database-disclosure/ What other large engagements/clients have you supported with this application? ---------------------------- None Technical Design ================ Describe the technology stack of the application and infrastructure. ---------------------------- MDN is a Python (Django) + MySQL app. CKEditor is a JavaScript + CSS widget. Will testing of the running application be possible? ---------------------------- Yes, via the staging server. Will source code for their application be available? ---------------------------- Yes, within this pull request: https://github.com/mozilla/kuma/pull/2948 Do you have attestation reports from any other vendors regarding your security posture? ---------------------------- I do not. Do you have any other security certifications that may be relevant? ---------------------------- I do not. Please let me know if I can help with anything. Before testing, however, please confirm with "davidwalsh", "groovecoder", or "openjck" that the correct CKEditor is on staging. It has a grey chrome. You can find us in #mdndev.
Flags: sec-review?
Commit pushed to ckeditor-update-updates-messages at https://github.com/mozilla/kuma https://github.com/mozilla/kuma/commit/f2b74a720743d503a4117cea58596c1c35c39c1e bug 975868 - Update the SAVE and S&KE button icons
Commit pushed to ckeditor-update-updates-messages at https://github.com/mozilla/kuma https://github.com/mozilla/kuma/commit/0ed109d01ecd782fc1405edecd6646ed2c28f31f Revert "bug 975868 - Update the SAVE and S&KE button icons" This reverts commit f2b74a720743d503a4117cea58596c1c35c39c1e.
Just an update that we're getting closer on the vendor security review blocker here. Expecting to clear it by next week.
Commits pushed to master at https://github.com/mozilla/kuma https://github.com/mozilla/kuma/commit/940c32ea0b776799e2027a26c03fb4b49f8ac6b9 bug 975868 - Started CKEditor v3 to v4 updated. https://github.com/mozilla/kuma/commit/aa70c202118c2c54f1e3dda3d2d12233b4badd8d bug 975868 - Added custom CKEditor 4.3.3 build. https://github.com/mozilla/kuma/commit/d5621b5d466c9fe0598cd6e6cd59e9574c884c2b bug 975868 - Started updating CKEditor config to match v4. https://github.com/mozilla/kuma/commit/03aa480b59bdd29e9785d64c4a56b94cb20b36df bug 975868 - Made it possible to easily switch between dev and production verion of CKEditor. https://github.com/mozilla/kuma/commit/a42893c605a02f155d0c1851d3d5b8c9baa48334 bug 975868 - Ported format buttons from old mdn-buttons plugin. https://github.com/mozilla/kuma/commit/e6be5959df1c6d80640542994994cdc09f7e7557 bug 975868 - Ported save and preview buttons from old mdn-buttons plugin. https://github.com/mozilla/kuma/commit/8ee8322acd2b7f99b314fb25f207d3b2e343e405 bug 975868 - Ported syntaxhighlighter plugin. https://github.com/mozilla/kuma/commit/195e20521ab0e303ff350ad33502b5005e75c13d bug 975868 - Ported mdn-keystrokes. https://github.com/mozilla/kuma/commit/db77589e03bde29e8afe82ccaa48af1b728e6d48 bug 975868 - Ported mdn-sampler plugin. https://github.com/mozilla/kuma/commit/b34457fe75a4298b32c99c00bc0b748fe4bcb845 bug 975868 - Copied tablesort plugin from CKEditor 3 to 4. https://github.com/mozilla/kuma/commit/9fc9890ab57b8850cc15fd6c7464b18e253494c1 bug 975868 - Aligned tablesort's lang file to CKE4. https://github.com/mozilla/kuma/commit/dc1f8cd793baaa966a4c5eb2509b32a371d4e0a4 bug 975868 - Updated custom CKEditor build. https://github.com/mozilla/kuma/commit/0dd18a6a9e8f8f04d71e4ee101b728158c7cfef8 bug 975868 - Pieces we hopefully don't need any more. https://github.com/mozilla/kuma/commit/167419ba4da114a0bde25832eea8e48b3935df29 bug 975868 - Ported mdn-redirect plugin. https://github.com/mozilla/kuma/commit/e56b4a381643f79f75e709793c09b05b0907cbcc bug 975868 - Updated CKEditor and its requirements submodules HEADs to 4.4.0. https://github.com/mozilla/kuma/commit/5463b391ce6f3b4c0dbe29e095a4479efa64cd67 bug 975868 - Rebuilt CKEditor. https://github.com/mozilla/kuma/commit/e0c8112435f8f8a3d2b5abc814002951ea3476f5 bug 975868 - Ported mdn-attachments. https://github.com/mozilla/kuma/commit/c88233445bbebf9f91f33b77f81328df99fdb781 bug 975868 - Ported mdn-sample-finder plugin. https://github.com/mozilla/kuma/commit/b28ccf71309f03e01a55a7fde331ddfa5b85da56 bug 975868 - Merge branch 'master' into ckeditor-update https://github.com/mozilla/kuma/commit/caea50e0030d832245c130b48a854ada777e527e bug 975868 - After merge fixes - brought back changes made to ckeditor_config.js on master between e2eb07263 and 735db76. https://github.com/mozilla/kuma/commit/ae8c66938aa9d6e9fc27ab2bcc1ebd5768109adc bug 975868 - Upgraded CKEditor and plugins to 4.4.4. https://github.com/mozilla/kuma/commit/4126404c840fa6a250ae0525c660e0d59483e5a8 bug 975868 - Rebuilt CKEditor. https://github.com/mozilla/kuma/commit/7cd6cc4beaf25d82ef186bf9d32a8a68ca4235b0 bug 975868 - Changed format of URLs to submodules. https://github.com/mozilla/kuma/commit/fdda4b7333b725a00d30ad20d01ec570bf587a4e bug 975868 - Added Reinmar/ckeditor-descriptionlist plugin as a replacement of old definitionlist plugin. https://github.com/mozilla/kuma/commit/61f338fa64ceb03c1b50e1aee920ac9b453d9444 bug 975868 - Extracted mdn-link-launch plugin from old mdn-link. https://github.com/mozilla/kuma/commit/d38c56a798c8a61d82fe772d042f5660cf431a36 bug 975868 - MDN's enter key plugin isn't needed any more. https://github.com/mozilla/kuma/commit/b90334aeab3d0e4c0cb47e77a993067aae5787b6 bug 975868 - Extracted mdn-table-customization plugin from old mdn-table plugin. https://github.com/mozilla/kuma/commit/4448b757cfe5d926d79149d2ac9a751f8d31ad87 bug 975868 - Rebuilt CKEditor. https://github.com/mozilla/kuma/commit/79977c384f14ad2932f7cf45487414daec818383 bug 975868 - Improved the way how table dialog is customised. https://github.com/mozilla/kuma/commit/54eb2a1d7789a2c38117d4f09bdb13f4824fbdfe bug 975868 - Portex texzilla plugin. https://github.com/mozilla/kuma/commit/be5792288c01eb0bda0685810b7e0b8150aae299 bug 975868 - Ported Youtube plugin. https://github.com/mozilla/kuma/commit/0f04cee0ef7a0b18b158b93368f4ca45c6dbda0e bug 975868 - Ported textzilla's icon. https://github.com/mozilla/kuma/commit/19491e3758eb1de41270e73c67ce808fe9f883a6 bug 975868 - Old browsers will fail on default used as a property name. https://github.com/mozilla/kuma/commit/c104c8b228644d7e5eb036835b66e1085a0acd2e bug 975868 - Rebuilt CKEditor. https://github.com/mozilla/kuma/commit/26cdb9b802062e7fc772abcaff26f5fd101fd3d0 bug 975868 - Added youtube's and textilla's icons in a way that CKBuilder can find and optimize them. https://github.com/mozilla/kuma/commit/0b530d7dad436d757924ddb7a226bf0b51d83778 bug 975868 - Rebuilt CKEditor. https://github.com/mozilla/kuma/commit/0a3f599f060da8cbd8a5164028ce7bed97509b31 bug 975868 - Ported mdn-spell plugin. https://github.com/mozilla/kuma/commit/c28971de25e43827a757460ab6af4aafedbd8d24 bug 975868 - Extracted modifications from mdn-image to mdn-image-attachment. https://github.com/mozilla/kuma/commit/5619e62b6816543adf3f4832203a5f72a3fcbf68 bug 975868 - Ported mdn-wrapstyle plugin. https://github.com/mozilla/kuma/commit/6597d92f7f57c0112f7a7542308f24fa1168e0d4 bug 975868 - Extracted changes from mdn-link plugin to a separate plugin. https://github.com/mozilla/kuma/commit/28cb5190406a68880156e4bbb64b3df90f1ca422 bug 975868 - Updated CKEditor submodule to 4.4.5. https://github.com/mozilla/kuma/commit/bd8d683ae59c52c55de46d34a966b64c696e0e36 bug 975868 - Rebuilt CKEditor prod version. https://github.com/mozilla/kuma/commit/fd0fb5b5258c712b2f23442cb645528dd6074007 bug 975868 - Implemented sticky toolbar. https://github.com/mozilla/kuma/commit/04849c55581e5a0d00b7ef40b91578c0629bbafa bug 975868 - Added vertical padding in the editing area. https://github.com/mozilla/kuma/commit/3f99dbb83fd82788919ce026e13c76c9330372c4 bug 975868 - Reorganized buttons in the toolbar. https://github.com/mozilla/kuma/commit/d50918a71c6e78731058f53148aceb3ce2ad1206 bug 975868 - Updated CSS selectors for save and preview buttons. https://github.com/mozilla/kuma/commit/f72d534e2a3a0b9eb76112fbe33a22812d04cf67 bug 975868 - Made styles drop down button and panel bigger. https://github.com/mozilla/kuma/commit/282303047acfbc2cc18f053c788c7d32df912f48 bug 975868 - Rebuilt CKEditor. https://github.com/mozilla/kuma/commit/ded36d8dfb531dd137c63a790a33199c737c1039 bug 975868 - Merge branch 'master' into ckeditor-update https://github.com/mozilla/kuma/commit/384d6b80ebd6b5bc17fdc09fc1d580b353624289 bug 975868 - Ported changes committed to master. https://github.com/mozilla/kuma/commit/004c71889d2c14d2906db0b26faa089787ba19cb bug 975868 - Ported some icons from the v3 and created some new. https://github.com/mozilla/kuma/commit/4176481f2f4297d17c21dda15cf6512e2a2aab97 bug 975868 - Desaturated icons ported from v3. https://github.com/mozilla/kuma/commit/b508dd04852192659299fd9cb46162421994a448 bug 975868 - Rebuilt CKEditor. https://github.com/mozilla/kuma/commit/faa20fd508f8fd44bc3fda843a55d8666fb9936b bug 975868 - Merge remote-tracking branch 'upstream/master' into ckeditor-update https://github.com/mozilla/kuma/commit/4aa673b6954a9ca0a469615f1b50b599e83fe4f8 bug 975868 - Merge remote-tracking branch 'upstream/master' into ckeditor-update https://github.com/mozilla/kuma/commit/649571e21b09b7f7b35107856bbb9437f958eb46 bug 975868 - Removed CKEditor 3 sources. https://github.com/mozilla/kuma/commit/7e4079444124680df363e58d57a33eed278477da bug 975868 - Updated descriptionlist plugin repository name. https://github.com/mozilla/kuma/commit/c1fef624e54ba856310841b0d1e3defae9e46bd4 bug 975868 - Updated descriptionlist plugin submodule HEAD. https://github.com/mozilla/kuma/commit/835a191848d210f929cd9a4b87c46f79639dc4c4 bug 975868 - Merge branch 'ckeditor-update' of https://github.com/Reinmar/kuma into ckeditor-update-updates https://github.com/mozilla/kuma/commit/ec9b0781f850747c2eabeb271038ca214b14d4ce bug 975868 - bug 975868 - Adding CKEditor post-build files, documentation for how to build CKE https://github.com/mozilla/kuma/commit/ecdbeb43684535a8d2c440bdaa3e32798c4a5c92 bug 975868 - bug 975868 - Add new document to index https://github.com/mozilla/kuma/commit/77c6b308c3e0dfee30a76b97851b74d097cb2a10 bug 975868 - Started CKEditor v3 to v4 updated. https://github.com/mozilla/kuma/commit/1d71275897b8861f741ce7f10de9a3c4db357d12 bug 975868 - Add built version of CKE https://github.com/mozilla/kuma/commit/bbf494d75bf39a1d6d272b32793fe7062e93974b bug 975868 - Switch to built version of CKE in template https://github.com/mozilla/kuma/commit/481e81a5a929c27df23ad5478512850d04c5608c bug 975868 - Updating submodule for plugins https://github.com/mozilla/kuma/commit/840f14ef6230ad8596f326059eee5e2f377ca03f bug 975868 - Update submodule for descriptor-list to no longer require submodule https://github.com/mozilla/kuma/commit/fd7214b83a399b7e72069c93cf07db3d1ecc99b9 bug 975868 - Update descriptor-list submodule commit https://github.com/mozilla/kuma/commit/95c00c43123ce09a1f2eb4129de01c0d5b4042b2 bug 975868 - Remove plugin submodules from CKE https://github.com/mozilla/kuma/commit/0f14e6fc3a7ecbd1d9eeaa3453cb1e96b8ee221b bug 975868 - Update build script with custom plugins, commit new build https://github.com/mozilla/kuma/commit/21049d95bb582837f44182dfd6d57d78eb0ff203 bug 975868 - Update build script with CKEditor checkout, remove its submodule https://github.com/mozilla/kuma/commit/80cdb0766d3bcf45c7846e13eb25b7b920234350 bug 975868 - Remove spellcheck plugin which isn't being used https://github.com/mozilla/kuma/commit/f2b74a720743d503a4117cea58596c1c35c39c1e bug 975868 - Update the SAVE and S&KE button icons https://github.com/mozilla/kuma/commit/0ed109d01ecd782fc1405edecd6646ed2c28f31f Revert "bug 975868 - Update the SAVE and S&KE button icons"
Merged and pushed yesterday.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Commits pushed to master at https://github.com/mozilla/kuma https://github.com/mozilla/kuma/commit/cda134e41ab4ed7f67df21bbfa3622bed29737be Bug 975868 - Upgrade CKEditor to 4.4.8 https://github.com/mozilla/kuma/commit/4e55f36f58a1f792bd8869c2c97cecb2951e5afa Merge pull request #3302 from darkwing/975868-ckeditor-upgrade-2 Bug 975868 - Upgrade CKEditor to 4.4.8
Flags: sec-review?
Product: developer.mozilla.org → developer.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.