975910 - [Camera] Hide Setting menu on click of other components of screen

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[singhashish1887]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:27.0) Gecko/20100101 Firefox/27.0 (Beta/Release)
Build ID: 20140212131424

Steps to reproduce:

1)Go to Camera application->click Setting icon->Setting Menu display
2) click on other component of screen other than close button .
 


Actual results:

Setting menu not disappear 


Expected results:

Setting menu should disappear or close

Comment 1

[singhashish1887]

Attachment: Pull Request

Comment 2

[singhashish1887]

Attachment: Pull Request (camera-dev) UT Test

Comment 3

[Diego Marcos [:dmarcos]]

Attachment: pull-request (camera-new-features)

Comment 4

[David Flanagan [:djf]]

Comment on attachment 8385818 [details] [review]
pull-request (camera-new-features)

r-

I'm pretty sure that this patch will break other things.  By removing the stopPropagation() calls, it means that touch events from the gallery and hud buttons will go through to the viewfinder and will probably do touch focus or something.

The settings panel is basically modal, and it should be consuming all events while it is visible.  Give it a transparent container that takes up the full screen, or register a capturing event handler for all touch and click events while it is visible.

Comment 5

[David Flanagan [:djf]]

I think I remember now that UX wants the shutter button to still function while the settings are visible.  That makes it trickier for the settings view to just capture all events.

I am fine with overruling UX on this and just capturing everything. In that case, the user would have to tap the shutter button twice: once to dismiss and once to take a picture.  Good enough for me if that is the easier way to implement this.

Otherwise, I think you'll need to modify all of the other event handlers in the camera to do something like emit an 'hidesettings' event or something, and have the settings panel listen for that event.  But I think that messing with the event propagation code is going to be bad.

Note that when touch focus and zoom land this is all going to get more complicated!

Comment 6

[Wilson Page [:wilsonpage]]

What does 'UT Test' mean?

Comment 7

[Wilson Page [:wilsonpage]]

Comment on attachment 8385792 [details] [review]
Pull Request (camera-dev) UT Test

r-

There are lots of anomalies in the code that suggest the author doesn't really understand what's going on. See Github comments.

Comment 8

[Hema Koka [:hema]]

Assigning to ashish who is working on this actively

Comment 9

[Mike Habicher [:mikeh] (high bugzilla latency)]

Hi Ashish, any progress on this issue?

Comment 10

[Wilson Page [:wilsonpage]]

The settings menu now fills the screen, so this is not longer valid.