975917 - [Everything.me] Tapping homebutton while in Collection Rename mode may cause freeze

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect, P1)

Description

[sync-1]

Firefox OS v1.3
 Mozilla build ID: 20140208004002
 
 DEFECT DESCRIPTION:
 MS will freeze when fast touch these folders "Social" "Games" "Music" "Showbiz" and home key.
 
  REPRODUCING PROCEDURES:
 At home screen, fast touch  "Social" /"Games"/ "Music" /"Showbiz" and home key many times, MS will freeze in "Social" /"Games"/ "Music" /"Showbiz" interface.--KO
 
  EXPECTED BEHAVIOUR:
 MS shouls not freeze when fast touch "Social" /"Games"/ "Music" /"Showbiz" and home key.
 
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 
  TOOLS AND PLATFORMS USED:
 
  USER IMPACT:
 
  REPRODUCING RATE:
 
  For FT PR, Please list reference mobile's behavior:

Comment 1

[Jason Smith [:jsmith]]

Can you include a video? That will help explain how fast we need to move to trigger the bug.

Comment 2

[sync-1]

Attachment: VI

Comment 3

[Jason Smith [:jsmith]]

The other thing we should find out here is if it's still possible to power down or restart the device when you hit this bug.

Comment 4

[xiupinglong]

(In reply to Jason Smith [:jsmith] from comment #3)
> The other thing we should find out here is if it's still possible to power
> down or restart the device when you hit this bug.

Yes, it can restart the phone.

Comment 5

[Vance Chen [:vchen][skype:vance.lucida][[e-mail]]]

Just find a relatively easy way to reproduce this issue:

1. Enter one collection, for example, Social
2. In Social collection, tap the title "Social" and then tap the Home key really fast, like a one-two punch, you must tap the home key before the virtual keyboard come up.
3. Screen will freeze. 

You need to operate quickly to reproduce this issue, but once it happens, you need to press power key to restart the handset, otherwise it will forever freeze in that screen

Comment 6

[xiupinglong]

Attachment: keyboard.png

We can find which causes this issue is the function this.Rename.done (in Collection.js). And sometimes the keyboard stay on the homescreen when no input field has focus.

Comment 7

[Ran Ben Aharon [:ranbena] EverythingMe]

Amir, can you take a look at this? See what component is responsible.

Comment 8

[Amir Nissim (:amirn)]

I am investigating. Might be a duplicate of bug 968628.

Comment 9

[Amir Nissim (:amirn)]

Attachment: Github Pull Request

Comment 10

[Amir Nissim (:amirn)]

Abrupt taps raised some issues timing issues with the Collection.Rename module.
E.me captures the homebutton tap but uncaught exceptions were blocking it from hiding the Rename UI. This caused the UI "freeze" and force the user to reboot.

I tried to make this patch as small as possible so it will be safe to land on 1.3.

For future reference, these errors showed up in the log:
(1) E/GeckoConsole( 2564): [JavaScript Error: "TypeError: elInput is null" {file: "app://homescreen.gaiamobile.org/everything.me/modules/Collection/Collection.js" line: 118}]

(2) Reported by bkelly in bug 968628
E/GeckoConsole( 3030): [JavaScript Error: "TypeError: currentSettings is null" {file: "app://homescreen.gaiamobile.org/everything.me/modules/Collection/Collection.js" line: 116}]

Comment 12

[Ran Ben Aharon [:ranbena] EverythingMe]

Comment on attachment 8381336 [details] [review]
Github Pull Request

Awesome. Couldn't reproduce.

Comment 13

[Amir Nissim (:amirn)]

landed in master: https://github.com/mozilla-b2g/gaia/commit/f03f667e1d92595df8bfddd8b0f0f7ec64d28230

Comment 14

[Amir Nissim (:amirn)]

Comment on attachment 8381336 [details] [review]
Github Pull Request

[v1.3 Approval Request Comment]
[Bug caused by]: bug 911550
[User impact] if declined: device might freeze when trying to rename a Collection and then quickly tapping the home button
[Risk to taking this patch]: Very Low. Changes only in Collection.Rename module
[String changes made]: Added safeguards

Comment 15

[bhavana bajaj [:bajaj]]

Given a phone restart is needed to get out of the freeze, lets uplift the low risk patch to avoid this regression.

Comment 16

[John Ford [:jhford] CET/CEST Berlin Time]

Uplift successful
Uplifted f03f667e1d92595df8bfddd8b0f0f7ec64d28230 to:
  * v1.3: b04d2a814a9916e63a51089ca62bba1ec52720b4