975963 - [keyboard refactor] Split keyboard.js into instancable App() and boot.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

+++ This bug was initially created as a clone of Bug #956169 +++

Split keyboard.js into instancable App() and boot.js, following the pattern of the future System app.

(with tests too!)

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Let me take this first.

Comment 2

[Mozilla Shepherd (This account is used for automation and doesn't receive bugmail)]

Attachment: mozilla-b2g:master PR#16559

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8380534 [details] [review]
mozilla-b2g:master PR#16559

It looks like doing conversion and writing tests in one patch is too much of a task, so let's land this first and start writing tests once all the conversions are completed.

Rudy, I don't think David has time for this. Would you review this for him?

Comment 4

[David Flanagan [:djf]]

Comment on attachment 8380534 [details] [review]
mozilla-b2g:master PR#16559

This looks fine to me. Thanks, Tim.

Comment 5

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8380534 [details] [review]
mozilla-b2g:master PR#16559

r=me.

Would be good if we can address jshint here, but maybe we want to do that in a follow up.
Thanks.

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

master: https://github.com/mozilla-b2g/gaia/commit/5bd7b743583bb61997936d02fefa3fe8f4db2f33