Closed
Bug 975966
Opened 11 years ago
Closed 11 years ago
[keyboard refactor] Convert suggestions.js to instantiable pattern
Categories
(Firefox OS Graveyard :: Gaia::Keyboard, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: timdream, Assigned: timdream)
References
Details
(Whiteboard: [ucid:SystemPlatform47, 1.5, ft:system-platform])
Attachments
(1 file)
+++ This bug was initially created as a clone of Bug #956169 +++
We need suggestions.js to be instantiable and started by another module.
Also jsdoc + unit test improvement wanted.
|
Assignee | |
Updated•11 years ago
|
Attachment #8382746 -
Flags: review?(rlu)
Attachment #8382746 -
Flags: feedback?(janjongboom)
Attachment #8382746 -
Flags: feedback?(dflanagan)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8382746 [details] [review]
mozilla-b2g:master PR#16684
r=me.
Thanks.
Attachment #8382746 -
Flags: review?(rlu) → review+
|
||
Comment 4•11 years ago
|
||
Comment on attachment 8382746 [details] [review]
mozilla-b2g:master PR#16684
Looks good to me.
Attachment #8382746 -
Flags: feedback?(dflanagan) → feedback+
|
||
Updated•11 years ago
|
Attachment #8382746 -
Flags: feedback?(janjongboom)
|
|
Assignee | |
Comment 5•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•9 years ago
|
Flags: in-testsuite? → in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•