Closed Bug 975966 Opened 9 years ago Closed 9 years ago

[keyboard refactor] Convert suggestions.js to instantiable pattern

Categories

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Keyboard
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: timdream, Assigned: timdream)

References

Details

(Whiteboard: [ucid:SystemPlatform47, 1.5, ft:system-platform])

Attachments

(1 file)

mozilla-b2g:master PR#16684
46 bytes, text/x-github-pull-request
rudyl
: review+
djf
: feedback+
Details | Review 
+++ This bug was initially created as a clone of Bug #956169 +++

We need suggestions.js to be instantiable and started by another module.

Also jsdoc + unit test improvement wanted.
WIP
Assignee: nobody → timdream
Status: NEW → ASSIGNED
Attachment #8382746 - Flags: review?(rlu)
Attachment #8382746 - Flags: feedback?(janjongboom)
Attachment #8382746 - Flags: feedback?(dflanagan)
Comment on attachment 8382746 [details] [review]
mozilla-b2g:master PR#16684

r=me.

Thanks.
Attachment #8382746 - Flags: review?(rlu) → review+
Comment on attachment 8382746 [details] [review]
mozilla-b2g:master PR#16684

Looks good to me.
Attachment #8382746 - Flags: feedback?(dflanagan) → feedback+
Attachment #8382746 - Flags: feedback?(janjongboom)
master: https://github.com/mozilla-b2g/gaia/commit/ab83e943351b7500bcb795b74d9e6e033a3ad28c
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Tests to be covered by bug 977451.
Flags: in-testsuite?
Flags: in-testsuite? → in-testsuite+
You need to log in before you can comment on or make changes to this bug.