976006 - Bookmark indicator does not update when adding a bookmark

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[catalin.suciu]

Nightly 30.0a1 (2014-02-23)

Bookmark star indicator does not update when adding a bookmark from the bookmarks submenu

Comment 1

[Brian Nicholson (:bnicholson)]

Is this actually a bug? We already have a checkbox next to Bookmark in the submenu. The star no longer just means "bookmark", it means "save using one of these actions".

Do we really want the star to change just from bookmarks being saved? This creates a visual disconnect between the other items in the submenu.

Comment 2

[Ian Barlow (:ibarlow)]

I think we should fill in the star if any one of these actions have been used to save something. Technically, Reading List and Homescreen items are both bookmarks, and Subscribed pages are close enough where it still warrants some visual indicator that the user has done something mark this page as important.

Comment 3

[Brian Nicholson (:bnicholson)]

Attachment: Update bookmark star when page is saved

As suggested by ibarlow on IRC, this highlights the star if the page is bookmarked and/or in the reading list.

Comment 4

[Brian Nicholson (:bnicholson)]

https://hg.mozilla.org/integration/fx-team/rev/ed1126d8728c

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/ed1126d8728c

Comment 6

[Flaviu Cos]

Verified as fixed in build 30.0a1 (2014-03-06);
Device: Lenovo Yoga Tab 10 (Android 4.2.2).