Closed Bug 976082 Opened 9 years ago Closed 9 years ago
Fu] Provide tests for touch adapter .
We need to write tests for the touch adapter and all the gestures it supports.
Added tests for touch adapter, also jshinted the jsatcommon and other files I touched.
Attachment #8385623 - Flags: review?(eitan)
Attachment #8385623 - Flags: review?(eitan) → review+
(In reply to Eitan Isaacson [:eeejay] from comment #2) > Comment on attachment 8385623 [details] [diff] [review] > 976082 patch v1 > > @@ +125,4 @@ > > return; > > } > > // Create an Iterator for gTestFuncs array. > > + gIterator = Iterator(gTestFuncs); // jshint ignore:line > > What error are you supressing? JSHint complains about a missing |new| in front of the Iterator, which is not necessary there.
One more thing.. > target.x = target.x || 0; > target.y = target.y || 0; On principal, I think we should avoid modifying argument data unless it is explicitly an out arg, so I would not assign this back to |target|.
This seems to have failed every single time it ran mochitest-oth on just Linux debug builds: https://tbpl.mozilla.org/php/getParsedLog.php?id=35689281&tree=Mozilla-Inbound Backed out in http://hg.mozilla.org/integration/mozilla-inbound/rev/cdb8fc90adff
Some improvements and speed up in the test harness.
Making timeouts more reliable. https://tbpl.mozilla.org/?tree=Try&rev=b9612f51a515
Comment on attachment 8388665 [details] [diff] [review] 976082 patch v3 Review of attachment 8388665 [details] [diff] [review]: ----------------------------------------------------------------- Looks good.
Attachment #8388665 - Flags: review+
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.