976105 - Remove test suite dependency on unprivileged calls to constructor-as-function

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Bobby Holley (:bholley)]

The goal here is to get the tree in a state such that it's green with and without the patch in bug 916644. I'm doing this in a separate bug so that, if we have to back out bug 916644, we don't have to revert all the test suite changes as well.

Test coverage for the specific behavior change in bug 916644 can land alongside that patch.

Comment 1

[Bobby Holley (:bholley)]

https://tbpl.mozilla.org/?tree=Try&rev=d83da4a9dc35

Comment 2

[Bobby Holley (:bholley)]

Attachment: Remove test-suite dependency on unprivileged calls to constructor-as-function. v1

Comment 3

[Bobby Holley (:bholley)]

Comment on attachment 8380701 [details] [diff] [review]
Remove test-suite dependency on unprivileged calls to constructor-as-function. v1

I think bz is busy today, so I'll flag Andrew here.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8380701 [details] [diff] [review]
Remove test-suite dependency on unprivileged calls to constructor-as-function. v1

The change to test_evaluator-constructor.html should get upstreamed in some form.

In test_bug370098.html should just change the test to ok(threw) for the non-"new" case.

>-  "XMLHttpRequest", "XPathEvaluator", "XSLTProcessor" ];
>+  "XMLHttpRequest", "XPathEvaluator" ];

Why this change?

r=me modulo that

Comment 5

[Bobby Holley (:bholley)]

(In reply to Boris Zbarsky [:bz] (reviews will be slow; ask someone else) from comment #4)
> The change to test_evaluator-constructor.html should get upstreamed in some
> form.

Ms2ger, do you know how to make this happen? Seems like we should automate this.
 
> In test_bug370098.html should just change the test to ok(threw) for the
> non-"new" case.

That would make this patch depend on the changes in bug 916644, which I'm trying to avoid. See comment 0. Sound ok?

> >-  "XMLHttpRequest", "XPathEvaluator", "XSLTProcessor" ];
> >+  "XMLHttpRequest", "XPathEvaluator" ];
> 
> Why this change?

I'd previously removed it before I decoupled this patch from bug 916644, since XSLTProcessor is on old-bindings and didn't throw. But with the aforementioned change, I can add it back, which I've done.

Comment 6

[Boris Zbarsky [:bzbarsky]]

> That would make this patch depend on the changes in bug 916644

todo(threw)?

Comment 7

[Bobby Holley (:bholley)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/889a90d8aa11

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

The change is wrong per the current spec, so won't be upstreamed. Don't touch our copy, but add it to the expected-failures list in dom/imptests/failures/.

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/889a90d8aa11

Comment 10

[Boris Zbarsky [:bzbarsky]]

> The change is wrong per the current spec

The current spec is widely considered to be buggy, though...

Comment 11

[[github robot]]

Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/4173680274c3088746b3da21bfdfeca58434f061
Bug 976105 - Remove test-suite dependency on unprivileged calls to constructor-as-function. r=bz