976131 - 400 response with an invalid message when trying to update app status via the API

Status: RESOLVED INCOMPLETE

(Marketplace Graveyard :: API, defect, P4)

Description

[Bob Silverberg [:bsilverberg]]

I am doing a PATCH to https://marketplace-dev.allizom.org:443/api/v1/apps/status/484243/ to update the status of an app. I _thought_ the status was 0, and was trying to update it to 'pending'. It turns out that in fact the status was already 'pending' (2), but the message I got back with the 400 response was something totally different.

The message was:

{"status":["You must provide at least one category.","You must upload at least one screenshot or video."]}

But the app did already have 2 categories added and a screenshot.

Mat suggested that this message might be due to caching as the cache may still think the app didn't have any categories or screenshots assigned.

In any case, the message should probably say something about trying to update an app to a status that it already has, so this is, possibly, another bug.

Comment 1

[akhil.ns01]

This bug Was so good and Looks interseting so i would like to fix it ...but i cannot Understand ...Please provide me further Detailed steps For Fixing this bug

Comment 2

[Ram Dayal Vaishnav [:ram]]

Hi Akhil, Bob should reply you soon about this. Meanwhile, you can try picking some other good-first-bug (few of them are listed at http://mzl.la/17oSqY8). 

Thanks,
Ram

Comment 3

[Bob Silverberg [:bsilverberg]]

I hate to pass the buck, but I won't be any help in actually working on this bug as I don't work on Marketplace or the Marketplace API. I just reported the bug because I found it while writing code for an automated test for the Marketplace web site. I think my initial report is pretty clear about what the bug is, but I'll summarize again:

If you use the Marketplace API to update an app submission, and you are trying to change the status, but the new status you are providing is the same as the current status, you receive a misleading error message. All of the details are in the initial description of the bug.

As for who could help mentor Akhil in working on the bug itself, I'm not sure. It would be someone on the Marketplace team.

Comment 4

[Ram Dayal Vaishnav [:ram]]

Hi Kevin/Marketplace Team, 

Could you please put here some info for newbie to pick and fix this bug?

Comment 5

[Andreas Wagner [:TheOne] [use NI]]

It is currently not very clear what exactly needs to be done here, and more so how it needs to be done. Please feel free to open a new bug with detailed information on how to fix it.