976165 - Set some sort of upper-limit on how many characters to feed into the annotated summary

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

In bug 967640, we hit an instance where log mangling caused huge lines to be fed into the annotated summary generator which led to browser hangs upon clicking a failed job on TBPL. We should probably truncate after a certain number of characters to avoid sending an overly-long string into the regex.

Comment 1

[Ed Morley [:emorley]]

Attachment: WIP

Need to test & play around with the number of characters (picked 500 for now).

Comment 2

[Ed Morley [:emorley]]

Attachment: Cap the line length to 500 characters in the annotated & brief log summary

I reduced the length down so it would trigger all the time, in order to test. For now let's just use 500 chars unless you would rather something else? :-)

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/webtools/tbpl/rev/cdbbecc4a6c8